Skip to content

fix: install.ps1 compatibility and improved path resolution #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anirudhpv wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −11
Open

fix: install.ps1 compatibility and improved path resolution #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,20 @@ param(
$ErrorActionPreference = "Stop"

# --- Project Directory Resolution ---
# Determine the root directory of the current git repository.
try {
$ProjectDirAbs = git rev-parse --show-toplevel 2>$null
if (-not $ProjectDirAbs) { throw "Not in a git repo" }
# Normalize path separator
$ProjectDirAbs = (Get-Item -LiteralPath $ProjectDirAbs).FullName
}
catch {
Write-Error "ERROR: This script must be run from within the google-ads-api-developer-assistant git repository."
exit 1
# Determine the root directory. Check local folder first for integration.
if (Test-Path ".\GEMINI.md") {
$ProjectDirAbs = (Get-Item ".\").FullName
} else {
try {
$ProjectDirAbs = git rev-parse --show-toplevel 2>$null
if (-not $ProjectDirAbs) { throw "Not in a git repo" }
# Normalize path separator
$ProjectDirAbs = (Get-Item -LiteralPath $ProjectDirAbs).FullName
}
catch {
Write-Error "ERROR: This script must be run from within the google-ads-api-developer-assistant git repository."
exit 1
}
}

Write-Host "Detected project root: $ProjectDirAbs"
Expand Down Expand Up @@ -99,7 +103,8 @@ if (-not (Get-Command git -ErrorAction SilentlyContinue)) {
# --- Path Resolution and Validation ---
Write-Host "Ensuring default library directory exists: $DefaultParentDir"
if (-not (Test-Path -LiteralPath $DefaultParentDir)) {
New-Item -ItemType Directory -Force -LiteralPath $DefaultParentDir | Out-Null
# Using -Path here for PS 5.1 compatibility as New-Item didn't support -LiteralPath until Core
New-Item -ItemType Directory -Force -Path $DefaultParentDir | Out-Null
}

# Helper to check if enabled
Expand Down