add support for Ads Assistant header via middleware#1152
Merged
Conversation
Change-Id: Ia8e2cbea26aba8942303c760939d3f1074bd3b2c
Contributor
Author
|
@bshaffer PTAL |
bshaffer
reviewed
Apr 20, 2026
bshaffer
left a comment
bshaffer
left a comment
Contributor
There was a problem hiding this comment.
This all seems good but we should have a test to verify this behavior works as expected!
| $headers[self::$LINKED_CUSTOMER_ID] = [$this->linkedCustomerId]; | ||
| } | ||
| if (!is_null($this->adsAssistant)) { | ||
| $headers[self::$ADS_ASSISTANT_HEADER_NAME] = [$this->adsAssistant]; |
Contributor
There was a problem hiding this comment.
We are okay with removing this header in favor of the new header? We don't want to send both?
Change-Id: I8a732385a29484892b982d914219e9080c040947
Contributor
Author
good call - wrote up and committed tests. Feel free to take a look. |
Contributor
Author
|
@bshaffer Can I get an updated review on whether this looks good to merge or not |
bshaffer
reviewed
May 11, 2026
Change-Id: I4953801db515a20ca681cf08be23f5234a121eff
Contributor
Author
|
@bshaffer Updated and got all tests passing. PTAL so I can go ahead with a merge |
Change-Id: I7cc6ade8a91924cd2b2de6dbe9faa848d1752861
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I encountered local environment issues with the gRPC extension version that prevented local tests from passing (v1.65.5 vs expected). I'm relying on the CI to verify the logic, as the environment there should be correctly configured.