Skip to content

Commit a289f5a

Browse files
Address comments
Change-Id: I78ec54d77cc1d9f6f3797e6fdd9293f3a33adadf
1 parent c1af3a4 commit a289f5a

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

examples/experiments/evaluate_and_update_experiment.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def main(client: GoogleAdsClient, customer_id: str, experiment_id: str) -> None:
6565
ga_service: GoogleAdsServiceClient = client.get_service("GoogleAdsService")
6666

6767
# Query to retrieve the experiment.
68-
# Notice that we request the statistical metrics (e.g., p-value, point estimate,
68+
# Notice that we request the statistical metrics (for example, p-value, point estimate,
6969
# margin of error) which are populated based on the treatment arm.
7070
query = f"""
7171
SELECT
@@ -110,7 +110,7 @@ def evaluate_experiment(
110110
client: GoogleAdsClient, customer_id: str, row: GoogleAdsRow
111111
) -> None:
112112
"""Evaluates the performance of the experiment and updates it accordingly
113-
(e.g. promotes, ends, or graduates).
113+
(for example, promotes, ends, or graduates).
114114
115115
Checks conversion and click metrics against statistical significance thresholds
116116
to determine the appropriate action to take on the experiment.
@@ -218,12 +218,12 @@ def evaluate_experiment(
218218
)
219219
print(
220220
f"Inconclusive: No significant action taken. {conv_status}, {click_status}."
221-
" Continue running."
221+
" Allowing the experiment to continue running."
222222
)
223223
else:
224224
print(
225225
"Conversion and click performance metrics are not yet populated. "
226-
"Continue running."
226+
"Allowing the experiment to continue running."
227227
)
228228
# [END evaluate_and_update_experiment_1]
229229

@@ -346,7 +346,7 @@ def graduate_experiment(
346346
)
347347
return
348348

349-
# 3. Build the Graduation Mapping and execute the graduation request.
349+
# 3. Build the budget mapping and execute the graduation request.
350350
experiment_service: ExperimentServiceClient = client.get_service(
351351
"ExperimentService"
352352
)
@@ -370,7 +370,8 @@ def graduate_experiment(
370370
if __name__ == "__main__":
371371
parser = argparse.ArgumentParser(
372372
description=(
373-
"Lists and evaluates performance metrics for a campaign experiment."
373+
"Retrieves performance metrics for an experiment, evaluates the"
374+
" performance and takes action on the experiment accordingly."
374375
)
375376
)
376377
# The following argument(s) should be provided to run the example.

0 commit comments

Comments
 (0)