update character limits for event parameters

Author: lindsey-volta

src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.spec.ts

@@ -43,4 +43,31 @@ describe("customSchema", () => {
 
         expect(validator.isValid(validInput)).toEqual(false)
     })
+
+    test("allows session_id to exceed 100 characters", () => {
+        const longString = "a".repeat(101)
+        const validInput = { session_id: longString }
+
+        let validator = new Validator(customSchema)
+
+        expect(validator.isValid(validInput)).toEqual(true)
+    })
+
+    test("allows session_number to exceed 100 characters", () => {
+        const longString = "a".repeat(101)
+        const validInput = { session_number: longString }
+
+        let validator = new Validator(customSchema)
+
+        expect(validator.isValid(validInput)).toEqual(true)
+    })
+
+    test("does not allow other properties to exceed 100 characters", () => {
+        const longString = "a".repeat(101)
+        const invalidInput = { other_param: longString }
+
+        let validator = new Validator(customSchema)
+
+        expect(validator.isValid(invalidInput)).toEqual(false)
+    })
 })

src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.ts

@@ -14,7 +14,8 @@ export const customSchema = {
     "required": [],
     "maxProperties": 25,
     "patternProperties": {
-        ".": {
+       "^(session_id|session_number)$": {},
+        "^(?!(session_id|session_number)$).*$": {
             "maxLength": 100
         }
     },

src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.spec.ts

@@ -0,0 +1,55 @@
+import "jest"
+import { Validator } from "../validator"
+import { buildEvents } from "./schemaBuilder"
+
+describe("schemaBuilder", () => {
+  const schema = {
+    allOf: buildEvents(),
+  }
+
+  const longString = "a".repeat(101)
+
+  it("allows session_id to exceed 100 characters for recommended events", () => {
+    const validator = new Validator(schema)
+    const event = {
+      name: "login",
+      params: {
+        session_id: longString,
+      },
+    }
+    expect(validator.isValid(event)).toBe(true)
+  })
+
+  it("allows session_number to exceed 100 characters for recommended events", () => {
+    const validator = new Validator(schema)
+    const event = {
+      name: "login",
+      params: {
+        session_number: longString,
+      },
+    }
+    expect(validator.isValid(event)).toBe(true)
+  })
+
+  it("does not allow other properties to exceed 100 characters for recommended events", () => {
+    const validator = new Validator(schema)
+    const event = {
+      name: "login",
+      params: {
+        method: longString,
+      },
+    }
+    expect(validator.isValid(event)).toBe(false)
+  })
+
+  it("validates a correct payload", () => {
+    const validator = new Validator(schema)
+    const event = {
+      name: "login",
+      params: {
+        method: "google",
+      },
+    }
+    expect(validator.isValid(event)).toBe(true)
+  })
+})

src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.ts

@@ -39,7 +39,8 @@ export const buildEvents = () => {
                                 40
                         },
                         "patternProperties": {
-                            ".": {
+                            "^(session_id|session_number)$": {},
+                            "^(?!(session_id|session_number)$).*$": {
                                 "maxLength": 100
                             }
                         }