Skip to content

Commit f5c5a0c

Browse files
committed
add test, cleanup deprecated method use in test file
1 parent 51e96f7 commit f5c5a0c

1 file changed

Lines changed: 23 additions & 4 deletions

File tree

src/components/ga4/EventBuilder/index.spec.tsx

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe("Event Builder", () => {
4949
const { wrapped } = withProviders(<Sut />, { isLoggedIn: false })
5050
const { findByLabelText, findByTestId } = renderer.render(wrapped)
5151

52-
await renderer.act(async () => {
52+
await React.act(async () => {
5353
// Choose the second view in the list
5454
const clientToggle = await findByTestId("use firebase")
5555
clientToggle.click()
@@ -94,7 +94,7 @@ describe("Event Builder", () => {
9494
exact: false,
9595
})
9696

97-
await renderer.act(async () => {
97+
await React.act(async () => {
9898
await userEvent.type(apiSecret, "my_secret", { delay: 1 })
9999
await userEvent.type(firebaseAppId, "my_firebase_app_id", {
100100
delay: 1,
@@ -145,7 +145,7 @@ describe("Event Builder", () => {
145145
wrapped
146146
)
147147

148-
await renderer.act(async () => {
148+
await React.act(async () => {
149149
// Choose the second view in the list
150150
const clientToggle = await findByTestId("use firebase")
151151
clientToggle.click()
@@ -166,7 +166,7 @@ describe("Event Builder", () => {
166166
exact: false,
167167
})
168168

169-
await renderer.act(async () => {
169+
await React.act(async () => {
170170
await userEvent.type(apiSecret, "my_secret", { delay: 1 })
171171
await userEvent.type(measurementId, "my_measurement_id", {
172172
delay: 1,
@@ -213,4 +213,23 @@ describe("Event Builder", () => {
213213
})
214214
})
215215
})
216+
describe("for firebase switch", () => {
217+
test("app only event ad_impression is not available", async () => {
218+
const { wrapped } = withProviders(<Sut />, { isLoggedIn: false })
219+
const { findByTestId } = renderer.render(wrapped)
220+
221+
await React.act(async () => {
222+
const clientToggle = await findByTestId("use firebase")
223+
clientToggle.click()
224+
})
225+
226+
const eventName = await findByTestId(Label.EventName)
227+
const enInput = within(eventName).getByRole("combobox")
228+
eventName.focus()
229+
renderer.fireEvent.change(enInput, { target: { value: "ad" } })
230+
231+
const adImpression = renderer.screen.queryByText("ad_impression")
232+
expect(adImpression).toBeNull()
233+
})
234+
})
216235
})

0 commit comments

Comments
 (0)