Skip to content

(chore)[]: resolve unit test issues#2226

Merged
lindsey-volta merged 5 commits into
mainfrom
event-builder-improvements
Aug 26, 2025
Merged

(chore)[]: resolve unit test issues#2226
lindsey-volta merged 5 commits into
mainfrom
event-builder-improvements

Conversation

@lindsey-volta
Copy link
Copy Markdown
Contributor

@lindsey-volta lindsey-volta commented Aug 26, 2025

Resolve unit test issues and failures & update formatting for external links.

  • Add @types/react and @types/react-dom to resolutions field to ensure consistent versioning across dependencies and resolve below unit test failures
    src/components/ga4/QueryExplorer/BasicReport/QueryExplorerLink.tsx:17:11 - error TS2786: 'Link' cannot be used as a JSX component.
  • Set noEmit to true to prevent tsc from outputting JS files to working directory and causing jest to run tests twice, causing failures.
  • Change div to span in ExternalLink to fix formatting across the site to make it more readable.

Before:

image

After:

image

@lindsey-volta lindsey-volta changed the title (draft)[]: resolve unit test issues (test)[]: resolve unit test issues Aug 26, 2025
@lindsey-volta lindsey-volta changed the title (test)[]: resolve unit test issues (chore)[]: resolve unit test issues Aug 26, 2025
@lindsey-volta lindsey-volta marked this pull request as ready for review August 26, 2025 17:01
@lindsey-volta lindsey-volta merged commit 5af3693 into main Aug 26, 2025
6 checks passed
@lindsey-volta lindsey-volta deleted the event-builder-improvements branch August 26, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants