Skip to content

Commit 33117b6

Browse files
committed
fix: address reviewer comments - move import to module level, join split string
1 parent df901cb commit 33117b6

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

analytics_mcp/tools/reporting/funnel.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,7 @@ async def run_funnel_report(
154154
)
155155
else:
156156
raise ValueError(
157-
f"Step {i+1} must contain either 'filter_expression' or"
158-
" 'event' key"
157+
f"Step {i+1} must contain either 'filter_expression' or 'event' key"
159158
)
160159

161160
funnel_step = data_v1alpha.FunnelStep(

analytics_mcp/tools/reporting/metadata.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
proto_to_dict,
2323
proto_to_json,
2424
)
25-
from google.analytics import data_v1beta
25+
from google.analytics import data_v1alpha, data_v1beta
2626

2727

2828
def get_date_ranges_hints():
@@ -57,8 +57,6 @@ def get_date_ranges_hints():
5757

5858
def get_funnel_steps_hints():
5959
"""Returns hints and examples for funnel steps configuration."""
60-
from google.analytics import data_v1alpha
61-
6260
step_first_open = data_v1alpha.FunnelStep(
6361
name="First open/visit",
6462
filter_expression=data_v1alpha.FunnelFilterExpression(

0 commit comments

Comments
 (0)