fix: replace bare except and remove unused import#140
Open
ZLeventer wants to merge 2 commits intogoogleanalytics:mainfrom
Open
fix: replace bare except and remove unused import#140ZLeventer wants to merge 2 commits intogoogleanalytics:mainfrom
ZLeventer wants to merge 2 commits intogoogleanalytics:mainfrom
Conversation
…ics#69) Strip redundant fields (name, parent, property_type) from account and property summaries to cut token usage for agencies with many GA4 accounts. Add an optional `query` parameter for case-insensitive display-name filtering so callers can narrow results without post-processing the full list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two minor code quality fixes:
analytics_mcp/tools/utils.pyline 33: Replace bareexcept:withexcept Exception:in_get_package_version_with_fallback(). A bare except catchesSystemExitandKeyboardInterrupt, which should propagate normally — onlyExceptionsubclasses (likePackageNotFoundError) should trigger the"unknown"fallback.analytics_mcp/coordinator.pyline 23: Remove unusedfrom json import toolimport. This symbol is never referenced in the file.Test plan
_get_package_version_with_fallback()still returns"unknown"when the package metadata is unavailable