address review feedback

parthea · parthea · commit 107fea49ae8e · 2025-03-28T23:36:43.000Z
diff --git a/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2 b/gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2
@@ -297,7 +297,7 @@ def _get_http_options():
                     "metadata": grpc_request["metadata"],
                 },
             )
-{% endmacro %}
+{%- endmacro %}
 
 
 {% macro prep_wrapped_messages_async_method(api, service) %}
diff --git a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc.py b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc.py
@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py b/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py
@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc.py b/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc.py
@@ -72,7 +72,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc_asyncio.py b/tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/transports/grpc_asyncio.py
@@ -76,7 +76,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/transports/grpc.py b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/transports/grpc.py
@@ -83,7 +83,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/transports/grpc_asyncio.py b/tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/transports/grpc_asyncio.py
@@ -87,7 +87,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/transports/grpc.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/transports/grpc.py
@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/transports/grpc_asyncio.py
@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/transports/grpc.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/transports/grpc.py
@@ -74,7 +74,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/transports/grpc_asyncio.py
@@ -78,7 +78,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc.py
@@ -74,7 +74,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc_asyncio.py
@@ -78,7 +78,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/transports/grpc.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/transports/grpc.py
@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/transports/grpc_asyncio.py
@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/transports/grpc.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/transports/grpc.py
@@ -74,7 +74,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/transports/grpc_asyncio.py
@@ -78,7 +78,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc.py
@@ -74,7 +74,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc_asyncio.py b/tests/integration/goldens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/transports/grpc_asyncio.py
@@ -78,7 +78,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/transports/grpc.py b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/transports/grpc.py
@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/transports/grpc_asyncio.py b/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/transports/grpc_asyncio.py
@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()
diff --git a/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/transports/grpc.py b/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/transports/grpc.py
@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = response.trailing_metadata()
diff --git a/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/transports/grpc_asyncio.py b/tests/integration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/transports/grpc_asyncio.py
@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request
                     "metadata": grpc_request["metadata"],
                 },
             )
-
         response = await continuation(client_call_details, request)
         if logging_enabled:  # pragma: NO COVER
             response_metadata = await response.trailing_metadata()

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ def _get_http_options():`
`297`	`297`	`"metadata": grpc_request["metadata"],`
`298`	`298`	`},`
`299`	`299`	`)`
`300`		`-{% endmacro %}`
	`300`	`+{%- endmacro %}`
`301`	`301`
`302`	`302`
`303`	`303`	`{% macro prep_wrapped_messages_async_method(api, service) %}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):`
`75`	`75`	`"metadata": grpc_request["metadata"],`
`76`	`76`	`},`
`77`	`77`	`)`
`78`		`-`
`79`	`78`	`response = continuation(client_call_details, request)`
`80`	`79`	`if logging_enabled: # pragma: NO COVER`
`81`	`80`	`response_metadata = response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request`
`79`	`79`	`"metadata": grpc_request["metadata"],`
`80`	`80`	`},`
`81`	`81`	`)`
`82`		`-`
`83`	`82`	`response = await continuation(client_call_details, request)`
`84`	`83`	`if logging_enabled: # pragma: NO COVER`
`85`	`84`	`response_metadata = await response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):`
`72`	`72`	`"metadata": grpc_request["metadata"],`
`73`	`73`	`},`
`74`	`74`	`)`
`75`		`-`
`76`	`75`	`response = continuation(client_call_details, request)`
`77`	`76`	`if logging_enabled: # pragma: NO COVER`
`78`	`77`	`response_metadata = response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request`
`76`	`76`	`"metadata": grpc_request["metadata"],`
`77`	`77`	`},`
`78`	`78`	`)`
`79`		`-`
`80`	`79`	`response = await continuation(client_call_details, request)`
`81`	`80`	`if logging_enabled: # pragma: NO COVER`
`82`	`81`	`response_metadata = await response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):`
`83`	`83`	`"metadata": grpc_request["metadata"],`
`84`	`84`	`},`
`85`	`85`	`)`
`86`		`-`
`87`	`86`	`response = continuation(client_call_details, request)`
`88`	`87`	`if logging_enabled: # pragma: NO COVER`
`89`	`88`	`response_metadata = response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,6 @@ async def intercept_unary_unary(self, continuation, client_call_details, request`
`87`	`87`	`"metadata": grpc_request["metadata"],`
`88`	`88`	`},`
`89`	`89`	`)`
`90`		`-`
`91`	`90`	`response = await continuation(client_call_details, request)`
`92`	`91`	`if logging_enabled: # pragma: NO COVER`
`93`	`92`	`response_metadata = await response.trailing_metadata()`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,6 @@ def intercept_unary_unary(self, continuation, client_call_details, request):`
`74`	`74`	`"metadata": grpc_request["metadata"],`
`75`	`75`	`},`
`76`	`76`	`)`
`77`		`-`
`78`	`77`	`response = continuation(client_call_details, request)`
`79`	`78`	`if logging_enabled: # pragma: NO COVER`
`80`	`79`	`response_metadata = response.trailing_metadata()`