fix: resolve issue where rest-numeric-enums=False is not supported (#2456)

Author: parthea

gapic/utils/options.py

@@ -167,6 +167,16 @@ def tweak_path(p):
             "TRUE",
         )
 
+        # `rest-numeric-enums` is False by default. Make sure users can also disable
+        # it by passing `rest-numeric-enums=False`.
+        rest_numeric_enums = opts.pop("rest-numeric-enums", ["False"])[0] in (
+            "True",
+            "true",
+            "T",
+            "t",
+            "TRUE",
+        )
+
         # NOTE: Snippets are not currently correct for the alternative (Ads) templates
         # so always disable snippetgen in that case
         # https://github.com/googleapis/gapic-generator-python/issues/1052
@@ -197,7 +207,7 @@ def tweak_path(p):
             # transport should include desired transports delimited by '+', e.g. transport='grpc+rest'
             transport=opts.pop("transport", ["grpc"])[0].split("+"),
             service_yaml_config=service_yaml_config,
-            rest_numeric_enums=bool(opts.pop("rest-numeric-enums", False)),
+            rest_numeric_enums=rest_numeric_enums,
             proto_plus_deps=proto_plus_deps,
             gapic_version=opts.pop("gapic-version", ["0.0.0"]).pop(),
         )

tests/unit/generator/test_options.py

@@ -212,6 +212,9 @@ def test_options_bool_flags():
     options = Options.build("autogen-snippets=False")
     assert not options.autogen_snippets
 
+    options = Options.build("rest-numeric-enums=False")
+    assert not options.rest_numeric_enums
+
 
 def test_options_autogen_snippets_false_for_old_naming():
     # NOTE: Snippets are not currently correct for the alternative (Ads) templates