Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 6dbb45b

Browse files
partheaparthea
committed
address feedback
1 parent 8a61d53 commit 6dbb45b

10 files changed

Lines changed: 35 additions & 35 deletions

File tree

‎.github/workflows/tests.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ env:
1818
PROTOC_VERSION: 3.20.2
1919
OLDEST_PYTHON: 3.7
2020
LATEST_STABLE_PYTHON: 3.14
21-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
2222
# Switch this to Python 3.15 alpha1 pre-release
2323
# https://peps.python.org/pep-0790/
2424
PRE_RELEASE_PYTHON: 3.14
25-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
25+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
2626
# Add Python 3.15 alpha1 pre-release
2727
# https://peps.python.org/pep-0790/
2828
ALL_PYTHON: "['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.14']"

‎gapic/ads-templates/noxfile.py.j2‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import os
77
import nox # type: ignore
88

99

10-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
10+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
1111
# Add tests for Python 3.15 alpha1
1212
# https://peps.python.org/pep-0790/
1313
ALL_PYTHON = [

‎gapic/templates/noxfile.py.j2‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ ALL_PYTHON = [
3232
"3.14",
3333
]
3434

35-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
36-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
37-
# Add tests for Python 3.15 alpha1
35+
DEFAULT_PYTHON_VERSION = "3.14"
36+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
37+
# Switch this to Python 3.15 alpha1
3838
# https://peps.python.org/pep-0790/
39-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
39+
PRE_RELEASE_PYTHON = "3.14"
4040

4141
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4242

‎tests/integration/goldens/asset/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/credentials/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/eventarc/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/logging/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/logging_internal/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/redis/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

‎tests/integration/goldens/redis_selective/noxfile.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@
3939
"3.14",
4040
]
4141

42-
DEFAULT_PYTHON_VERSION = ALL_PYTHON[-1]
43-
# TOOD(https://github.com/googleapis/gapic-generator-python/issues/2450):
44-
# Add tests for Python 3.15 alpha1
42+
DEFAULT_PYTHON_VERSION = "3.14"
43+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2450):
44+
# Switch this to Python 3.15 alpha1
4545
# https://peps.python.org/pep-0790/
46-
PRE_RELEASE_PYTHON = ALL_PYTHON[-1]
46+
PRE_RELEASE_PYTHON = "3.14"
4747

4848
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
4949

0 commit comments

Comments
 (0)