This repository was archived by the owner on Mar 26, 2026. It is now read-only.
File tree Expand file tree Collapse file tree 8 files changed +8
-96
lines changed
tests/integration/goldens Expand file tree Collapse file tree 8 files changed +8
-96
lines changed Original file line number Diff line number Diff line change @@ -248,27 +248,16 @@ def install_unittest_dependencies(session, *constraints):
248248@nox.session(python =ALL_PYTHON)
249249@nox.parametrize(
250250 " protobuf_implementation" ,
251- [ " python" , " upb" , " cpp " ],
251+ [ " python" , " upb" ],
252252)
253253def unit(session, protobuf_implementation):
254254 # Install all test dependencies, then install this package in-place.
255255
256- # TODO(https: //github.com /googleapis /gapic-generator-python /issues /2388):
257- # Remove this check once support for Protobuf 3.x is dropped.
258- if protobuf_implementation == " cpp" and session.python in ( " 3.11" , " 3.12" , " 3.13" , " 3.14" ):
259- session.skip( " cpp implementation is not supported in python 3.11+" )
260-
261256 constraints_path = str(
262257 CURRENT_DIRECTORY / " testing" / f " constraints-{session.python}.txt"
263258 )
264259 install_unittest_dependencies(session, " -c" , constraints_path)
265260
266- # TODO(https: //github.com /googleapis /gapic-generator-python /issues /2388):
267- # Remove the ' cpp' implementation once support for Protobuf 3.x is dropped.
268- # The ' cpp' implementation requires Protobuf <4.
269- if protobuf_implementation == " cpp" :
270- session.install( " protobuf<4" )
271-
272261 # Run py.test against the unit tests.
273262 session.run(
274263 " py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
Original file line number Diff line number Diff line change @@ -246,27 +246,16 @@ def install_unittest_dependencies(session, *constraints):
246246@nox .session (python = ALL_PYTHON )
247247@nox .parametrize (
248248 "protobuf_implementation" ,
249- ["python" , "upb" , "cpp" ],
249+ ["python" , "upb" ],
250250)
251251def unit (session , protobuf_implementation ):
252252 # Install all test dependencies, then install this package in-place.
253253
254- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
255- # Remove this check once support for Protobuf 3.x is dropped.
256- if protobuf_implementation == "cpp" and session .python in ("3.11" , "3.12" , "3.13" , "3.14" ):
257- session .skip ("cpp implementation is not supported in python 3.11+" )
258-
259254 constraints_path = str (
260255 CURRENT_DIRECTORY / "testing" / f"constraints-{ session .python } .txt"
261256 )
262257 install_unittest_dependencies (session , "-c" , constraints_path )
263258
264- # TODO(https://github.com/googleapis/gapic-generator-python/issues/2388):
265- # Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
266- # The 'cpp' implementation requires Protobuf<4.
267- if protobuf_implementation == "cpp" :
268- session .install ("protobuf<4" )
269-
270259 # Run py.test against the unit tests.
271260 session .run (
272261 "py.test" ,
You can’t perform that action at this time.
0 commit comments