Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit af9e49c

Browse files
1 parent 8f9ff68 commit af9e49c

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

gapic/samplegen/samplegen.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,9 @@ def _fill_sample_metadata(sample: dict, api_schema: api.API):
11201120

11211121
# Client Method
11221122
setattr(snippet_metadata.client_method, "async", async_)
1123-
snippet_metadata.client_method.short_name = utils.to_snake_case(method.client_method_name)
1123+
snippet_metadata.client_method.short_name = utils.to_snake_case(
1124+
method.client_method_name
1125+
)
11241126
snippet_metadata.client_method.full_name = f"{snippet_metadata.client_method.client.full_name}.{snippet_metadata.client_method.short_name}"
11251127

11261128
if not method.void:

tests/unit/schema/test_api.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4130,7 +4130,9 @@ def test_selective_gapic_api_build_generate_omitted_as_internal():
41304130
== "BaseServiceOneAsyncClient"
41314131
)
41324132
assert (
4133-
api_schema.all_methods["google.example.v1.ServiceOne.InternalMethod"].client_method_name
4133+
api_schema.all_methods[
4134+
"google.example.v1.ServiceOne.InternalMethod"
4135+
].client_method_name
41344136
== "_InternalMethod"
41354137
)
41364138

tests/unit/schema/wrappers/test_method.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -968,13 +968,11 @@ def test_client_method_name():
968968
safe_methods = {name: make_method(name=name) for name in ["Call", "Put", "Hold"]}
969969

970970
internal_unsafe_methods = {
971-
k: dataclasses.replace(v, is_internal=True)
972-
for k, v in unsafe_methods.items()
971+
k: dataclasses.replace(v, is_internal=True) for k, v in unsafe_methods.items()
973972
}
974973

975974
internal_safe_methods = {
976-
k: dataclasses.replace(v, is_internal=True)
977-
for k, v in safe_methods.items()
975+
k: dataclasses.replace(v, is_internal=True) for k, v in safe_methods.items()
978976
}
979977

980978
for name, method in safe_methods.items():
@@ -985,7 +983,7 @@ def test_client_method_name():
985983

986984
for name, method in internal_safe_methods.items():
987985
assert method.client_method_name == f"_{name}"
988-
986+
989987
for name, method in internal_unsafe_methods.items():
990988
assert method.client_method_name == f"_{name}_"
991989

0 commit comments

Comments
 (0)