Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit b786cc2

Browse files
committed
clarify comment
1 parent c090d34 commit b786cc2

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

gapic/templates/setup.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ dependencies = [
4242
{# Explicitly exclude protobuf versions mentioned in https://cloud.google.com/support/bulletins#GCP-2022-019 #}
4343
"protobuf>=3.20.2,<7.0.0,!=4.21.0,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
4444
{% for package_tuple, package_info in pypi_packages.items() %}
45-
{# Quick check to make sure `package_info.package_name` is not the package being generated. #}
45+
{# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #}
4646
{% if api.naming.warehouse_package_name != package_info.package_name %}
4747
{% if api.requires_package(package_tuple) %}
4848
"{{ package_info.package_name }} >= {{ package_info.lower_bound }}, <{{ package_info.upper_bound }}",

gapic/templates/testing/_default_constraints.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ google-api-core
55
proto-plus
66
protobuf
77
{% for package_tuple, package_info in pypi_packages.items() %}
8-
{# Quick check to make sure `package_info.package_name` is not the package being generated. #}
8+
{# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #}
99
{% if api.naming.warehouse_package_name != package_info.package_name %}
1010
{% if api.requires_package(package_tuple) %}
1111
{{ package_info.package_name }}

gapic/templates/testing/constraints-3.13.txt.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ google-auth>=2
1010
proto-plus>=1
1111
protobuf>=6
1212
{% for package_tuple, package_info in pypi_packages.items() %}
13-
{# Quick check to make sure `package_info.package_name` is not the package being generated. #}
13+
{# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #}
1414
{% if api.naming.warehouse_package_name != package_info.package_name %}
1515
{% if api.requires_package(package_tuple) %}
1616
{{ package_info.package_name }}>={{ (package_info.upper_bound.split(".")[0] | int) - 1 }}

gapic/templates/testing/constraints-3.7.txt.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ google-auth==2.14.1
1010
proto-plus==1.22.3
1111
protobuf==3.20.2
1212
{% for package_tuple, package_info in pypi_packages.items() %}
13-
{# Quick check to make sure `package_info.package_name` is not the package being generated. #}
13+
{# Quick check to make sure `package_info.package_name` is not the package being generated so we don't circularly include this package in its own constraints file. #}
1414
{% if api.naming.warehouse_package_name != package_info.package_name %}
1515
{% if api.requires_package(package_tuple) %}
1616
{{ package_info.package_name }}=={{ package_info.lower_bound }}

0 commit comments

Comments
 (0)