Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit e18c7d2

Browse files
partheaparthea
committed
add TODO comments; restore exclude
1 parent b40c170 commit e18c7d2

8 files changed

Lines changed: 80 additions & 24 deletions

File tree

‎gapic/templates/.flake8.j2‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,17 @@
33
{% block content %}
44

55
[flake8]
6-
ignore = E501 # ignore E501 `line too long`
6+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
7+
# Resolve flake8 lint issues
8+
ignore = E203, E231, E266, E501, W503
79
exclude =
8-
# Exclude protobuf gencode.
9-
*_pb2.py*
10+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
11+
# Ensure that generated code passes flake8 lint
12+
**/gapic/**
13+
**/services/**
14+
**/types/**
15+
# Exclude Protobuf gencode
16+
*_pb2.py
1017

1118
# Standard linting exemptions.
1219
**/.nox/**

‎tests/integration/goldens/asset/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/credentials/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/eventarc/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/logging/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/logging_internal/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/redis/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

‎tests/integration/goldens/redis_selective/.flake8‎

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,17 @@
1414
# limitations under the License.
1515
#
1616
[flake8]
17-
ignore = E501 # ignore E501 `line too long`
17+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
18+
# Resolve flake8 lint issues
19+
ignore = E203, E231, E266, E501, W503
1820
exclude =
19-
# Exclude protobuf gencode.
20-
*_pb2.py*
21+
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333):
22+
# Ensure that generated code passes flake8 lint
23+
**/gapic/**
24+
**/services/**
25+
**/types/**
26+
# Exclude Protobuf gencode
27+
*_pb2.py
2128

2229
# Standard linting exemptions.
2330
**/.nox/**

0 commit comments

Comments
 (0)