Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit e9615e7

Browse files
committed
address PR feedback
1 parent dbfe132 commit e9615e7

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

gapic/templates/%namespace/%name_%version/%sub/__init__.py.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ if hasattr(api_core, "check_python_version") and hasattr(api_core, "check_depend
5353
{# TODO(api_core): remove `type:ignore` below when minimum version of api_core makes the else clause unnecessary. #}
5454
api_core.check_python_version("{{package_path}}") # type: ignore
5555
api_core.check_dependency_versions("{{package_path}}") # type: ignore
56-
{# Add `# fmt: skip` to keep `# pragma: NO COVER` on the same line #}
57-
else: # pragma: NO COVER # fmt: skip
56+
else: # pragma: NO COVER
5857
{# TODO(api_core): Remove this try-catch when we require api-core at a version that
5958
supports the changes in https://github.com/googleapis/python-api-core/pull/832
6059

gapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,7 @@ def _get_http_options():
270270

271271
{% macro unary_request_interceptor_common(service) %}
272272
logging_enabled = CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(std_logging.DEBUG)
273-
{# Add `# fmt: skip` to keep `# pragma: NO COVER` on the same line #}
274-
if logging_enabled: # pragma: NO COVER # fmt: skip
273+
if logging_enabled: # pragma: NO COVER
275274
request_metadata = client_call_details.metadata
276275
if isinstance(request, proto.Message):
277276
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2293): Investigate if we can improve this logic

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc_asyncio.py.j2

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,7 @@ class _LoggingClientAIOInterceptor(grpc.aio.UnaryUnaryClientInterceptor): # pra
6868
async def intercept_unary_unary(self, continuation, client_call_details, request):
6969
{{ shared_macros.unary_request_interceptor_common(service) }}
7070
response = await continuation(client_call_details, request)
71-
{# Add `# fmt: skip` to keep `# pragma: NO COVER` on the same line #}
72-
if logging_enabled: # pragma: NO COVER # fmt: skip
71+
if logging_enabled:
7372
response_metadata = await response.trailing_metadata()
7473
# Convert gRPC metadata `<class 'grpc.aio._metadata.Metadata'>` to list of tuples
7574
metadata = dict([(k, str(v)) for k, v in response_metadata]) if response_metadata else None

0 commit comments

Comments
 (0)