Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: address mypy failures #2411

Closed
parthea wants to merge 3 commits into from
Closed

fix: address mypy failures #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cbf371
fix: address mypy failures
parthea Jun 18, 2025
abb1ca4
workaround 2473
parthea Nov 3, 2025
c66c681
workaround 2473
parthea Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/_async_mixins.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions gapic/templates/%namespace/%name_%version/%sub/services/%service/_mixins.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion gapic/templates/mypy.ini.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
14 changes: 14 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,13 @@ def fragment(session, use_ads_templates=False):
)
session.install("-e", ".")

# TODO(https://github.com/googleapis/gapic-generator-python/issues/2473):
# Warnings emitted from google-api-core starting in 2.28
# appear to cause issues when running protoc.
# The specific failure is `Plugin output is unparseable`
if session.python in ("3.7", "3.8", "3.9", "3.10"):
session.install("google-api-core<2.28")

frag_files = (
[Path(f) for f in session.posargs] if session.posargs else FRAGMENT_FILES
)
Expand Down Expand Up @@ -238,6 +245,13 @@ def showcase_library(
# Install grpcio-tools for protoc
session.install("grpcio-tools")

# TODO(https://github.com/googleapis/gapic-generator-python/issues/2473):
# Warnings emitted from google-api-core starting in 2.28
# appear to cause issues when running protoc.
# The specific failure is `Plugin output is unparseable`
if session.python in ("3.7", "3.8", "3.9", "3.10"):
session.install("google-api-core<2.28")

# Install a client library for Showcase.
with tempfile.TemporaryDirectory() as tmp_dir:
# Download the Showcase descriptor.
Expand Down
9 changes: 5 additions & 4 deletions tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3189,10 +3189,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3589,10 +3589,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/goldens/asset/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
2 changes: 1 addition & 1 deletion tests/integration/goldens/credentials/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
9 changes: 5 additions & 4 deletions ...s/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2637,10 +2637,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions tests/integration/goldens/eventarc/google/cloud/eventarc_v1/services/eventarc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3066,10 +3066,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/goldens/eventarc/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
9 changes: 5 additions & 4 deletions ...ration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3985,10 +3985,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions .../integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4385,10 +4385,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...ation/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,10 +1100,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,10 +1459,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...ation/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,10 +951,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,10 +1310,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/goldens/logging/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
9 changes: 5 additions & 4 deletions ...ldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3985,10 +3985,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...ion/goldens/logging_internal/google/cloud/logging_v2/services/config_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4385,10 +4385,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...dens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,10 +1100,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...on/goldens/logging_internal/google/cloud/logging_v2/services/logging_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,10 +1459,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...dens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,10 +951,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions ...on/goldens/logging_internal/google/cloud/logging_v2/services/metrics_service_v2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,10 +1310,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/goldens/logging_internal/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
9 changes: 5 additions & 4 deletions tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1858,10 +1858,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
9 changes: 5 additions & 4 deletions tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2245,10 +2245,11 @@ def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._validate_universe_domain()
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/goldens/redis/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.7
python_version = 3.8
namespace_packages = True
9 changes: 5 additions & 4 deletions ...ration/goldens/redis_selective/google/cloud/redis_v1/services/cloud_redis/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,10 +1051,11 @@ async def get_operation(

# Certain fields should be provided within the metadata header;
# add these here.
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)
if request is not None:
metadata = tuple(metadata) + (
gapic_v1.routing_header.to_grpc_metadata(
(("name", request.name),)),
)

# Validate the universe domain.
self._client._validate_universe_domain()
Expand Down
Loading
Loading