chore: remove pin for types-protobuf to support 3.14#2544
chore: remove pin for types-protobuf to support 3.14#2544
Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates a dependency specification to resolve a compatibility issue, enabling the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the version pin for types-protobuf to support Python 3.14. The change is logical, but to improve future maintainability, I've suggested adding an inline comment to document the reason for unpinning this dependency. This provides helpful context for other developers.
| session.install( | ||
| "mypy", | ||
| "types-protobuf<=3.19.7", | ||
| "types-protobuf", |
There was a problem hiding this comment.
While removing the pin is necessary, it's good practice to document why a dependency is unpinned, especially when it was pinned before. This provides context for future maintainers. An inline comment would be a great addition here.
| "types-protobuf", | |
| "types-protobuf", # Unpinned to support Python 3.14+ |
This is required to support running mypy with the latest version of Python i.e. 3.14