test(source/cloud-sql-mysql): create MCP integration tests#2922
Merged
Conversation
dishaprakash
changed the base branch from
main
to
anubhav-feat-native-mcp-alloydb
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive integration tests for the Model Context Protocol (MCP) across various data sources, including AlloyDB, Cloud SQL MySQL, and HTTP. It also adds modular helper functions in tests/mcp_tool.go to facilitate standardized MCP tool testing. Several issues were identified in the review: a critical flaw in the Cloud SQL MySQL instance creation test where mocking http.DefaultClient fails to affect the separate toolbox process, and multiple violations of the repository style guide regarding tool naming conventions (snake_case and product name exclusion). Additionally, the use of time.Sleep in MySQL tests was flagged as a potential source of flakiness, and some error assertions were noted as being too weak.
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
db1827c to
7c651a9
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
from
69bb59b to
d81edf8
Compare
dishaprakash
changed the title
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
94d7fce to
e3fa5a6
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
from
d81edf8 to
4c21e3f
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
0019b41 to
0a48e1c
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
11 times, most recently
from
16be479 to
f643196
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
082b05d to
225d74f
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
from
f643196 to
2e6e044
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
from
2e6e044 to
5a9f6bd
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
e698ea1 to
072f36b
Compare
anubhav756
force-pushed
the
anubhav-feat-native-mcp-alloydb
branch
from
5a9f6bd to
d2bdddd
Compare
dishaprakash
force-pushed
the
mcp-cloud-sql-mysql-tests
branch
from
1ac28ca to
25cfb2a
Compare
Yuan325
approved these changes
Apr 24, 2026
Yuan325
reviewed
Apr 24, 2026
Yuan325
added
the
release candidate
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
pavankrishna13
pushed a commit
to pavankrishna13/genai-toolbox
that referenced
this pull request
May 19, 2026
…s#2922) ## Description This PR migrates the Cloud SQL MySQL integration tests to use the /mcp endpoint on the MCP Toolbox Server. ### Key Changes - `tests/mcp_tool.go`: - Added modular builder functions (Base, ExecuteSQL, TemplateParams) to dynamically generate expected MCP manifests. - Added concatenation of individual MCP text blocks into a fully formatted JSON array whenever the test expects one, preserving compatibility with previous test assertions. - `cloud_sql_mysql_mcp_test.go`: Migrated legacy `/api` tests to `/mcp` - `cloud_sql_mysql_create_instance_mcp_test.go`: Migrated create-instance tests to validate MCP JSON-RPC handling. - `tests/options.go`: Added functional options for the various MySQL test fixtures to provide an MCP tests specific path - `tests/tool.go`: Used the above mentioned options to allow calling MCP Endpoints in the test fixtures of MySQL --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the Cloud SQL MySQL integration tests to use the /mcp endpoint on the MCP Toolbox Server.
Key Changes
tests/mcp_tool.go:cloud_sql_mysql_mcp_test.go: Migrated legacy/apitests to/mcpcloud_sql_mysql_create_instance_mcp_test.go: Migrated create-instance tests to validate MCP JSON-RPC handling.tests/options.go: Added functional options for the various MySQL test fixtures to provide an MCP tests specific pathtests/tool.go: Used the above mentioned options to allow calling MCP Endpoints in the test fixtures of MySQL