Skip to content

Commit 8eba83c

Browse files
chore: Addressing gemini code review comments
1 parent d391df9 commit 8eba83c

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

Src/Support/Google.Apis.Tests/Apis/Upload/ResumableUploadTest.MultiChunk.cs

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ public void TestUploadInPartialServer(
507507
/// </summary>
508508
[Theory, CombinatorialData]
509509
public void TestChunkedUpload_CompletesAndVerifiesChecksumInPartialServer(
510-
[CombinatorialValues(true)] bool knownSize,
510+
[CombinatorialValues(true, false)] bool knownSize,
511511
[CombinatorialValues(80, 150)] int partialSize,
512512
[CombinatorialValues(100, 200)] int chunkSize)
513513
{
@@ -521,10 +521,19 @@ public void TestChunkedUpload_CompletesAndVerifiesChecksumInPartialServer(
521521
var progress = uploader.Upload();
522522
Assert.Equal(expectedCallCount, server.Requests.Count);
523523
var request = server.Requests.Last();
524-
Assert.Contains(ResumableUpload.GoogleHashHeader, request.Headers.AllKeys);
525-
var headerValue = request.Headers[ResumableUpload.GoogleHashHeader];
526-
var expectedBase64Hash = CalculateCrc32c(UploadTestBytes);
527-
Assert.Equal($"crc32c={expectedBase64Hash}", headerValue);
524+
525+
if (knownSize)
526+
{
527+
Assert.Contains(ResumableUpload.GoogleHashHeader, request.Headers.AllKeys);
528+
var headerValue = request.Headers[ResumableUpload.GoogleHashHeader];
529+
var expectedBase64Hash = CalculateCrc32c(UploadTestBytes);
530+
Assert.Equal($"crc32c={expectedBase64Hash}", headerValue);
531+
}
532+
else
533+
{
534+
Assert.DoesNotContain(ResumableUpload.GoogleHashHeader, request.Headers.AllKeys);
535+
}
536+
528537
Assert.Equal(UploadTestBytes, server.Bytes);
529538
Assert.Equal(UploadStatus.Completed, progress.Status);
530539
}
@@ -536,9 +545,8 @@ public void TestChunkedUpload_CompletesAndVerifiesChecksumInPartialServer(
536545
[Fact]
537546
public async Task TestInitiateSessionWithMatchingCrc32c()
538547
{
539-
int partialSize = 80;
540548
var content = new MemoryStream(UploadTestBytes);
541-
using (var server = new MultiChunkPartialServer(_server, partialSize))
549+
using (var server = new MultiChunkServer(_server))
542550
using (var service = new MockClientService(server.HttpPrefix))
543551
{
544552
var chunkSize = 1024;
@@ -567,9 +575,8 @@ public async Task TestInitiateSessionWithMatchingCrc32c()
567575
[Fact]
568576
public async Task TestInitiateSessionWithMismatchingCrc32c()
569577
{
570-
int partialSize = 80;
571578
var content = new MemoryStream(UploadTestBytes);
572-
using (var server = new MultiChunkPartialServer(_server, partialSize))
579+
using (var server = new MultiChunkServer(_server))
573580
using (var service = new MockClientService(server.HttpPrefix))
574581
{
575582
var chunkSize = 1024;

0 commit comments

Comments
 (0)