feat: API regeneration: release-2026-04-27.08-02-31#3158
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the DeveloperKnowledge.v1 API and updates several existing libraries, including ChromeManagement, CustomerEngagementSuite, and WorkspaceEvents, with new features such as experiment configurations and additional OAuth scopes. Feedback highlights that the generated C# code for DisplayVideo.v2 is missing, which leaves the library out of sync with its updated discovery document. Additionally, a repetitive description in the Games.v1 discovery file was noted for correction.
| <PropertyGroup> | ||
| <Title>Google.Apis.DisplayVideo.v2 Client Library</Title> | ||
| <Version>1.73.0.4119</Version> | ||
| <Version>1.73.0.4128</Version> |
There was a problem hiding this comment.
The discovery document DiscoveryJson/displayvideo.v2.json has been updated with a new property allowNonSkippableInStream and several description changes, but the corresponding generated C# file Src/Generated/Google.Apis.DisplayVideo.v2/Google.Apis.DisplayVideo.v2.cs is missing from the pull request. This will result in the library being out of sync with the API definition.
| "enumDescriptions": [ | ||
| "Default value. Should not be used.", | ||
| "The achievement is active and published, and can be earned by players.", | ||
| "The achievement is archived. It cannot be earned by players, and is hidden from players who have not already unlocked it. from players who haven't unlocked it." |
There was a problem hiding this comment.
There is a repetitive phrase in the description: "from players who have not already unlocked it. from players who haven't unlocked it." It should be cleaned up for better clarity.
| "The achievement is archived. It cannot be earned by players, and is hidden from players who have not already unlocked it. from players who haven't unlocked it." | |
| "The achievement is archived. It cannot be earned by players, and is hidden from players who have not already unlocked it." |
2 participants
Changes in this PR will be published to Nuget on the next release cycle.