Skip to content

deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0#28713

Merged
lqiu96 merged 2 commits intomainfrom
lqiu96-patch-1
Aug 21, 2025
Merged

deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0#28713
lqiu96 merged 2 commits intomainfrom
lqiu96-patch-1

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Aug 21, 2025 •
edited
Loading

No description provided.

@lqiu96 lqiu96 requested review from a team and blakeli0 August 21, 2025 15:11
blakeli0
blakeli0 reviewed Aug 21, 2025
View reviewed changes
Comment thread generator/src/googleapis/codegen/languages/java/2.0.0/features.json Outdated
@@ -6,7 +6,7 @@
"baseClientLibrary": "2.8.1",
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be downgraded as well, otherwise you may get transitive dependency of http-client.

Copy link
Copy Markdown
Member Author

@lqiu96 lqiu96 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, looks like baseClientLibrary is the only dep that is brought in from the generated client (

google-api-java-client-services/clients/google-api-services-storage/v1/2.0.0/pom.xml

Lines 123 to 129 in d95831f

<dependencies>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client</artifactId>
<version>2.8.1</version>
</dependency>
</dependencies>
)

Not entirely sure what the httpClientLibrary variable is used for then. I guess I'll keep it as the old version as well then just in case

Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomarquezp Other than baseClientLibrary, do you know what other variables are used for?

Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than a few are not used. I believe they were meant for other dependencies, but now everything is managed from google-api-client, which contains versions for auth, jackson, etc.

I'll follow on this with a cleanup

@lqiu96 lqiu96 requested a review from blakeli0 August 21, 2025 16:20
@lqiu96 lqiu96 changed the title deps: Downgrade google-http-client to v1.47.1 deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0 Aug 21, 2025
@lqiu96 lqiu96 changed the title deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0 deps: Downgrade google-http-client to v1.47.1, google-api-java-client to v2.8.0 Aug 21, 2025
@lqiu96 lqiu96 changed the title deps: Downgrade google-http-client to v1.47.1, google-api-java-client to v2.8.0 deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0 Aug 21, 2025
@lqiu96 lqiu96 merged commit b59277c into main Aug 21, 2025
35 of 36 checks passed
@lqiu96 lqiu96 deleted the lqiu96-patch-1 branch August 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lqiu96 @blakeli0 @diegomarquezp