Skip to content

deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0 #28713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 2 commits into from
Aug 21, 2025
Merged

deps: Downgrade google-http-client to v1.47.1 and google-api-java-client to v2.8.0 #28713

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f5a8e5
deps: Downgrade google-http-client to v1.47.1
lqiu96 Aug 21, 2025
7094b64
chore: Downgrade google-api-client to v2.8.0
lqiu96 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/src/googleapis/codegen/languages/java/2.0.0/features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"baseClientLibrary": "2.8.1",
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be downgraded as well, otherwise you may get transitive dependency of http-client.

Copy link
Copy Markdown
Member Author

@lqiu96 lqiu96 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, looks like baseClientLibrary is the only dep that is brought in from the generated client (

google-api-java-client-services/clients/google-api-services-storage/v1/2.0.0/pom.xml

Lines 123 to 129 in d95831f

<dependencies>
<dependency>
<groupId>com.google.api-client</groupId>
<artifactId>google-api-client</artifactId>
<version>2.8.1</version>
</dependency>
</dependencies>
)

Not entirely sure what the httpClientLibrary variable is used for then. I guess I'll keep it as the old version as well then just in case

Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomarquezp Other than baseClientLibrary, do you know what other variables are used for?

Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than a few are not used. I believe they were meant for other dependencies, but now everything is managed from google-api-client, which contains versions for auth, jackson, etc.

I'll follow on this with a cleanup

"oauthClientLibrary": "1.39.0",
"gsonVersion": "2.11.0",
"httpClientLibrary": "2.0.0",
"httpClientLibrary": "1.47.1",
"httpClientVersion": "4.5.14",
"jackson2CoreVersion": "2.19.0",
"jdo2ApiVersion": "2.3-eb",
Expand Down
Loading