Skip to content

chore: coerce res.data into an array of objects #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofisl merged 4 commits into from
Jun 18, 2025
Merged

chore: coerce res.data into an array of objects #3686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b0a2ef
fix broken type
sofisl Jun 17, 2025
12e9cd7
remove logging
sofisl Jun 17, 2025
45cb722
update test
sofisl Jun 18, 2025
2a3acc4
remove only
sofisl Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/generator/disclaimer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,14 @@ export const gfs = {
*/
export async function main() {
const res = await request<LibraryMetadata[]>({url: libraryListUrl});
const disclaimers = res.data.map(lib => {
return {
api: lib.api_id.split('.')[0],
package: lib.distribution_name,
};
});
const disclaimers = JSON.parse(res.data as unknown as string).map(
(lib: LibraryMetadata) => {
return {
api: lib.api_id.split('.')[0],
package: lib.distribution_name,
};
},
);
gfs.writeFileSync('./disclaimers.json', JSON.stringify(disclaimers, null, 2));
}

Expand Down
37 changes: 20 additions & 17 deletions test/test.disclaimer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,27 @@ import * as nock from 'nock';
import {URL} from 'url';
import * as disclaimer from '../src/generator/disclaimer';

const mockResponse = [
const mockResponse = `[
{
name: 'asset',
name_pretty: 'Asset Inventory',
product_documentation:
'https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview',
client_documentation: 'https://googleapis.dev/nodejs/asset/latest',
issue_tracker: 'https://issuetracker.google.com/savedsearches/559757',
release_level: 'ga',
language: 'nodejs',
repo: 'googleapis/nodejs-asset',
distribution_name: '@google-cloud/asset',
api_id: 'cloudasset.googleapis.com',
requires_billing: true,
support_documentation:
'https://cloud.google.com/resource-manager/docs/getting-support',
},
];
"name": "cloudasset",
"name_pretty": "Asset Inventory",
"product_documentation": "https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview",
"client_documentation": "https://cloud.google.com/nodejs/docs/reference/asset/latest",
"issue_tracker": "https://issuetracker.google.com/savedsearches/559757",
"release_level": "stable",
"language": "nodejs",
"repo": "googleapis/google-cloud-node",
"distribution_name": "@google-cloud/asset",
"api_id": "cloudasset.googleapis.com",
"requires_billing": true,
"default_version": "v1",
"codeowner_team": "@googleapis/cloud-asset-team",
"api_shortname": "cloudasset",
"library_type": "GAPIC_AUTO",
"linkToRepoHomepage": "https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-asset",
"support_documentation": "https://cloud.google.com/resource-manager/docs/getting-support"
}
]`;

nock.disableNetConnect();

Expand Down
Loading