Skip to content

fix: cast generated header values to strings#2717

Merged
bshaffer merged 2 commits into
googleapis:mainfrom
GrahamCampbell:fix/psr7-string-header-values
Jun 8, 2026
Merged

fix: cast generated header values to strings#2717
bshaffer merged 2 commits into
googleapis:mainfrom
GrahamCampbell:fix/psr7-string-header-values

Conversation

@GrahamCampbell

@GrahamCampbell GrahamCampbell commented May 23, 2026

Copy link
Copy Markdown
Contributor

Hi there. The Guzzle maintainer here again. I am working on the next major version of Guzzle with a focus on security hardening and reducing security-foot guns. As part of those changes, the next major version will disallow non-string header values. I will be triggering deprecations soon on the current major version series, which will start to impact this project, unless it is first modified to stop passing non-string header values. And thus, that is what this PR does.


FYI, there is a similar PR open on a sister repo at googleapis/google-cloud-php#9208.

@GrahamCampbell GrahamCampbell requested a review from a team as a code owner May 23, 2026 22:53
@google-cla

google-cla Bot commented May 23, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer

bshaffer commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

We need to update symfony/dom-crawler to version 5 or higher to resolve the vulnerability which is failing the tests

@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

I think that would be out of scope for this PR.

@GrahamCampbell

Copy link
Copy Markdown
Contributor Author

#2718

@bshaffer bshaffer merged commit 1441bb1 into googleapis:main Jun 8, 2026
16 of 18 checks passed
@GrahamCampbell GrahamCampbell deleted the fix/psr7-string-header-values branch June 8, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants