feat(mtls): fix lint

Author: andyrzhao

oauth2_http/java/com/google/auth/mtls/ContextAwareMetadataJson.java

@@ -45,4 +45,4 @@ public class ContextAwareMetadataJson extends GenericJson {
   public final ImmutableList<String> getCommands() {
     return ImmutableList.copyOf(commands);
   }
-}
+}

oauth2_http/java/com/google/auth/mtls/DefaultMtlsProviderFactory.java

@@ -31,28 +31,27 @@
 
 package com.google.auth.mtls;
 
-import com.google.auth.mtls.CertificateSourceUnavailableException;
-import com.google.auth.mtls.X509Provider;
 import java.io.IOException;
 
 public class DefaultMtlsProviderFactory {
 
   /**
-   * Creates an instance of {@link MtlsProvider}. It first attempts to create an
-   * {@link X509Provider}. If the certificate source is unavailable, it falls back to creating a
-   * {@link SecureConnectProvider}. If the secure connect provider also fails, it throws the
-   * original {@link CertificateSourceUnavailableException}.
+   * Creates an instance of {@link MtlsProvider}. It first attempts to create an {@link
+   * com.google.auth.mtls.X509Provider}. If the certificate source is unavailable, it falls back to
+   * creating a {@link SecureConnectProvider}. If the secure connect provider also fails, it throws
+   * the original {@link com.google.auth.mtls.CertificateSourceUnavailableException}.
    *
    * @return an instance of {@link MtlsProvider}.
-   * @throws CertificateSourceUnavailableException if neither provider can be created.
+   * @throws com.google.auth.mtls.CertificateSourceUnavailableException if neither provider can be
+   *     created.
    * @throws IOException if an I/O error occurs during provider creation.
    */
   public static MtlsProvider create() throws IOException {
     MtlsProvider mtlsProvider;
     try {
-       mtlsProvider = new X509Provider();
-       mtlsProvider.getKeyStore();
-       return mtlsProvider;
+      mtlsProvider = new X509Provider();
+      mtlsProvider.getKeyStore();
+      return mtlsProvider;
     } catch (CertificateSourceUnavailableException e) {
       try {
         mtlsProvider = new SecureConnectProvider();
@@ -64,4 +63,4 @@ public static MtlsProvider create() throws IOException {
       }
     }
   }
-}
+}

oauth2_http/java/com/google/auth/mtls/MtlsProvider.java

@@ -37,4 +37,4 @@
 public interface MtlsProvider {
   /** Returns the mutual TLS key store. */
   KeyStore getKeyStore() throws IOException;
-}
+}

oauth2_http/java/com/google/auth/mtls/SecureConnectProvider.java

@@ -48,7 +48,7 @@
  * Provider class for mutual TLS. It is used to configure the mutual TLS in the transport with the
  * default client certificate on device.
  */
-public class SecureConnectProvider implements MtlsProvider{
+public class SecureConnectProvider implements MtlsProvider {
   interface ProcessProvider {
     public Process createProcess(InputStream metadata) throws IOException;
   }
@@ -88,9 +88,11 @@ public KeyStore getKeyStore() throws IOException {
     } catch (InterruptedException e) {
       throw new IOException("Interrupted executing certificate provider command", e);
     } catch (GeneralSecurityException e) {
-      throw new CertificateSourceUnavailableException("SecureConnect encountered GeneralSecurityException:", e);
+      throw new CertificateSourceUnavailableException(
+          "SecureConnect encountered GeneralSecurityException:", e);
     } catch (FileNotFoundException exception) {
-      // If the metadata file doesn't exist, then there is no key store, so we will throw sentinel error
+      // If the metadata file doesn't exist, then there is no key store, so we will throw sentinel
+      // error
       throw new CertificateSourceUnavailableException("SecureConnect metadata does not exist.");
     }
   }
@@ -145,4 +147,4 @@ static int runCertificateProviderCommand(Process commandProcess, long timeoutMil
     commandProcess.destroy();
     throw new IOException("cert provider command timed out");
   }
-}
+}

oauth2_http/java/com/google/auth/mtls/X509Provider.java

@@ -48,7 +48,7 @@
  * libraries, and the public facing methods may be changed without notice, and have no guarantee of
  * backwards compatability.
  */
-public class X509Provider implements MtlsProvider{
+public class X509Provider implements MtlsProvider {
   static final String CERTIFICATE_CONFIGURATION_ENV_VARIABLE = "GOOGLE_API_CERTIFICATE_CONFIG";
   static final String WELL_KNOWN_CERTIFICATE_CONFIG_FILE = "certificate_config.json";
   static final String CLOUDSDK_CONFIG_DIRECTORY = "gcloud";

oauth2_http/javatests/com/google/auth/mtls/SecureConnectProviderTest.java

@@ -32,8 +32,6 @@
 package com.google.auth.mtls;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
@@ -113,16 +111,15 @@ public void testGetKeyStoreNonZeroExitCode()
         assertThrows(
             IOException.class,
             () -> SecureConnectProvider.getKeyStore(metadata, new TestProcessProvider(1)));
-    assertTrue("expected to fail with nonzero exit code",
+    assertTrue(
+        "expected to fail with nonzero exit code",
         actual.getMessage().contains("Cert provider command failed with exit code: 1"));
   }
 
   @Test
   public void testExtractCertificateProviderCommand() throws IOException {
     InputStream inputStream =
-        this.getClass()
-            .getClassLoader()
-            .getResourceAsStream("mtls_context_aware_metadata.json");
+        this.getClass().getClassLoader().getResourceAsStream("mtls_context_aware_metadata.json");
     List<String> command = SecureConnectProvider.extractCertificateProviderCommand(inputStream);
     assertEquals(2, command.size());
     assertEquals("some_binary", command.get(0));
@@ -143,19 +140,20 @@ public void testRunCertificateProviderCommandTimeout() throws InterruptedExcepti
         assertThrows(
             IOException.class,
             () -> SecureConnectProvider.runCertificateProviderCommand(certCommandProcess, 100));
-    assertTrue("expected to fail with timeout",
+    assertTrue(
+        "expected to fail with timeout",
         actual.getMessage().contains("cert provider command timed out"));
   }
 
   @Test
-  public void testGetKeyStore_FileNotFoundException() throws IOException, GeneralSecurityException, InterruptedException {
-    SecureConnectProvider provider = new SecureConnectProvider(new TestProcessProvider(0), "/invalid/metadata/path.json");
+  public void testGetKeyStore_FileNotFoundException()
+      throws IOException, GeneralSecurityException, InterruptedException {
+    SecureConnectProvider provider =
+        new SecureConnectProvider(new TestProcessProvider(0), "/invalid/metadata/path.json");
 
-    CertificateSourceUnavailableException exception = assertThrows(
-        CertificateSourceUnavailableException.class,
-            provider::getKeyStore
-    );
+    CertificateSourceUnavailableException exception =
+        assertThrows(CertificateSourceUnavailableException.class, provider::getKeyStore);
 
     assertEquals("SecureConnect metadata does not exist.", exception.getMessage());
   }
-}
+}