fix: handle error-prone warnings (#1334)

* fix: pom.xml - remove duplicate dependencies / plugin clauses that cause warnings

This prevents the following errors:

$ mvn install -DskipTests=true
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model for com.google.auth:google-auth-library-oauth2-http:jar:1.20.1-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> duplicate declaration of version (?) @ line 249, column 17
[WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-failsafe-plugin @ line 193, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]

* fix: add missing @OverRide annotations on overriding methods

---------

Co-authored-by: Noam Lewis <noamlewis@google.com>
Co-authored-by: Timur Sadykov <stim@google.com>

Author: 3 people

appengine/java/com/google/auth/appengine/AppEngineCredentials.java

@@ -139,6 +139,7 @@ public static Builder newBuilder() {
     return new Builder();
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -175,6 +176,7 @@ public AppIdentityService getAppIdentityService() {
       return appIdentityService;
     }
 
+    @Override
     public AppEngineCredentials build() {
       return new AppEngineCredentials(scopes, appIdentityService);
     }

oauth2_http/java/com/google/auth/oauth2/CloudShellCredentials.java

@@ -115,6 +115,7 @@ public boolean equals(Object obj) {
     return this.authPort == other.authPort;
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -142,6 +143,7 @@ public int getAuthPort() {
       return authPort;
     }
 
+    @Override
     public CloudShellCredentials build() {
       return new CloudShellCredentials(authPort);
     }

oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

@@ -535,6 +535,7 @@ private void readObject(ObjectInputStream input) throws IOException, ClassNotFou
     transportFactory = newInstance(transportFactoryClassName);
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -675,6 +676,7 @@ public Collection<String> getDefaultScopes() {
       return defaultScopes;
     }
 
+    @Override
     public ComputeEngineCredentials build() {
       return new ComputeEngineCredentials(this);
     }

oauth2_http/java/com/google/auth/oauth2/DownscopedCredentials.java

@@ -185,6 +185,7 @@ public Builder setHttpTransportFactory(HttpTransportFactory transportFactory) {
       return this;
     }
 
+    @Override
     public DownscopedCredentials build() {
       return new DownscopedCredentials(
           sourceCredential, credentialAccessBoundary, transportFactory);

oauth2_http/java/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentials.java

@@ -294,6 +294,7 @@ public boolean equals(Object obj) {
         && Objects.equals(this.quotaProjectId, credentials.quotaProjectId);
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -501,6 +502,7 @@ public Builder setClientSecret(String clientSecret) {
      * @param quotaProjectId the quota and billing project id to set
      * @return this {@code Builder} object
      */
+    @Override
     @CanIgnoreReturnValue
     public Builder setQuotaProjectId(String quotaProjectId) {
       super.setQuotaProjectId(quotaProjectId);
@@ -513,12 +515,14 @@ public Builder setQuotaProjectId(String quotaProjectId) {
      * @param accessToken the access token
      * @return this {@code Builder} object
      */
+    @Override
     @CanIgnoreReturnValue
     public Builder setAccessToken(AccessToken accessToken) {
       super.setAccessToken(accessToken);
       return this;
     }
 
+    @Override
     public ExternalAccountAuthorizedUserCredentials build() {
       return new ExternalAccountAuthorizedUserCredentials(this);
     }

oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java

@@ -848,6 +848,7 @@ public Builder setTokenInfoUrl(String tokenInfoUrl) {
      * @param quotaProjectId the quota and billing project id to set
      * @return this {@code Builder} object
      */
+    @Override
     @CanIgnoreReturnValue
     public Builder setQuotaProjectId(String quotaProjectId) {
       super.setQuotaProjectId(quotaProjectId);
@@ -941,6 +942,7 @@ Builder setEnvironmentProvider(EnvironmentProvider environmentProvider) {
       return this;
     }
 
+    @Override
     public abstract ExternalAccountCredentials build();
   }
 }

oauth2_http/java/com/google/auth/oauth2/GdchCredentials.java

@@ -311,6 +311,7 @@ public static Builder newBuilder() {
     return new Builder();
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -475,6 +476,7 @@ public int getLifetime() {
       return lifetime;
     }
 
+    @Override
     public GdchCredentials build() {
       return new GdchCredentials(this);
     }

oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java

@@ -406,6 +406,7 @@ public static Builder newBuilder() {
     return new Builder();
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder(this);
   }
@@ -502,6 +503,7 @@ protected Builder(GoogleCredentials.Builder builder) {
       this.universeDomain = builder.universeDomain;
     }
 
+    @Override
     public GoogleCredentials build() {
       return new GoogleCredentials(this);
     }

oauth2_http/java/com/google/auth/oauth2/IdTokenCredentials.java

@@ -149,6 +149,7 @@ public boolean equals(Object obj) {
         && Objects.equals(this.targetAudience, other.targetAudience);
   }
 
+  @Override
   public Builder toBuilder() {
     return new Builder()
         .setIdTokenProvider(this.idTokenProvider)
@@ -198,6 +199,7 @@ public List<IdTokenProvider.Option> getOptions() {
       return this.options;
     }
 
+    @Override
     public IdTokenCredentials build() {
       return new IdTokenCredentials(this);
     }

oauth2_http/java/com/google/auth/oauth2/IdentityPoolCredentials.java

@@ -183,6 +183,7 @@ public static class Builder extends ExternalAccountCredentials.Builder {
       super(credentials);
     }
 
+    @Override
     @CanIgnoreReturnValue
     public Builder setWorkforcePoolUserProject(String workforcePoolUserProject) {
       super.setWorkforcePoolUserProject(workforcePoolUserProject);