Skip to content

Commit 1d8889b

Browse files
committed
docs: phpdoc warning for external credentials
1 parent 3053a5b commit 1d8889b

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

src/Credentials/ExternalAccountCredentials.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,15 @@
3535
use GuzzleHttp\Psr7\Request;
3636
use InvalidArgumentException;
3737

38+
/**
39+
* **IMPORTANT**:
40+
* This class does not validate the credential configuration. A security
41+
* risk occurs when a credential configuration configured with malicious urls
42+
* is used.
43+
* When the credential configuration is accepted from an
44+
* untrusted source, you should validate it before using with this method.
45+
* [documentation] https://cloud.google.com/docs/authentication/external/externally-sourced-credentials for more details.
46+
*/
3847
class ExternalAccountCredentials implements
3948
FetchAuthTokenInterface,
4049
UpdateMetadataInterface,

src/Credentials/ImpersonatedServiceAccountCredentials.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@
3030
use InvalidArgumentException;
3131
use LogicException;
3232

33+
/**
34+
* **IMPORTANT**:
35+
* This class does not validate the credential configuration. A security
36+
* risk occurs when a credential configuration configured with malicious urls
37+
* is used.
38+
* When the credential configuration is accepted from an
39+
* untrusted source, you should validate it before using with this method.
40+
* [documentation] https://cloud.google.com/docs/authentication/external/externally-sourced-credentials for more details.
41+
*/
3342
class ImpersonatedServiceAccountCredentials extends CredentialsLoader implements
3443
SignBlobInterface,
3544
GetUniverseDomainInterface

0 commit comments

Comments
 (0)