Skip to content

Commit 02eeddb

Browse files
committed
resolve gemini code review comments
1 parent 5b3ca47 commit 02eeddb

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

google/cloud/storage/internal/async/object_descriptor_impl.cc

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,12 @@ void ObjectDescriptorImpl::Start(
6565
}
6666

6767
bool ObjectDescriptorImpl::IsOpen() const {
68-
std::unique_lock<std::mutex> lk(mu_);
69-
if (cancelled_) return false;
70-
if (stream_manager_->Empty()) return false;
71-
return transport_ok_();
68+
{
69+
std::unique_lock<std::mutex> lk(mu_);
70+
if (cancelled_) return false;
71+
if (stream_manager_->Empty()) return false;
72+
}
73+
return !transport_ok_ || transport_ok_();
7274
}
7375

7476
void ObjectDescriptorImpl::Cancel() {

google/cloud/storage/internal/async/object_descriptor_impl.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ class ObjectDescriptorImpl
126126
google::cloud::StatusOr<storage_internal::OpenStreamResult>>
127127
pending_stream_;
128128
bool cancelled_ = false;
129-
bool permanent_failure_ = false;
130129
std::function<bool()> transport_ok_;
131130
};
132131

0 commit comments

Comments
 (0)