Skip to content

Commit 044d1ea

Browse files
committed
address gemini review comments
1 parent 75b49e6 commit 044d1ea

2 files changed

Lines changed: 2 additions & 21 deletions

File tree

google/cloud/bigtable/data_connection_test.cc

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -74,25 +74,6 @@ TEST(MakeDataConnection, TracingEnabled) {
7474
Contains(SpanNamed("bigtable::Table::Apply")));
7575
}
7676

77-
TEST(MakeDataConnection, InstanceChannelAffinityOption) {
78-
InstanceResource instance_a{Project("my-project"), "instance-a"};
79-
InstanceResource instance_b{Project("my-project"), "instance-b"};
80-
auto conn = MakeDataConnection(
81-
TestOptions()
82-
.set<AppProfileIdOption>("user-supplied")
83-
.set<bigtable_internal::InstanceChannelAffinityOption>(
84-
{instance_a, instance_b}));
85-
auto options = conn->options();
86-
EXPECT_TRUE(options.has<DataBackoffPolicyOption>())
87-
<< "Options are not defaulted in MakeDataConnection()";
88-
EXPECT_EQ(options.get<AppProfileIdOption>(), "user-supplied")
89-
<< "User supplied Options are overridden in MakeDataConnection()";
90-
ASSERT_TRUE(options.has<bigtable_internal::InstanceChannelAffinityOption>());
91-
EXPECT_THAT(
92-
options.get<bigtable_internal::InstanceChannelAffinityOption>().size(),
93-
Eq(2));
94-
}
95-
9677
TEST(MakeDataConnection, TracingDisabled) {
9778
auto span_catcher = testing_util::InstallSpanCatcher();
9879

google/cloud/bigtable/options.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,8 @@ struct QueryPlanRefreshFunctionRetryPolicyOption {
180180
* If `MakeDataConnection(std::vector<InstanceResource>, Options)` is called,
181181
* then all connections will be managed by a Dynamic Channel Pool. The
182182
* `DynamicChannelPoolSizingPolicy` can be provided via the
183-
* `DynamicChannelPoolSizingPolicyOption` and configures the behavior of the
184-
* `DynamicChannelPool`.
183+
* `experimental::DynamicChannelPoolSizingPolicyOption` and configures the
184+
* behavior of the `DynamicChannelPool`.
185185
*/
186186
struct DynamicChannelPoolSizingPolicy {
187187
// Removing unused channels is not as performance critical as adding channels

0 commit comments

Comments
 (0)