Merge branch 'main' into for_google

Author: marete

.bazelversion

@@ -1 +1 @@
-7.4.1
+7.6.1

.clang-tidy

@@ -26,6 +26,13 @@
 #      avoiding C arrays often makes the code less readable, and std::array is
 #      not a drop-in replacement because it doesn't deduce the size.
 #
+#  -modernize-type-traits: clang-tidy recommands using c++17 style variable
+#      templates. We will enable this check after we moved to c++17.
+#
+#  -modernize-unary-static-assert: clang-tidy asks removing empty string in
+#      static_assert(), the check is only applicable for c++17 and later code.
+#      We will enable this check after we moved to c++17.
+#
 #  -performance-move-const-arg: This warning requires the developer to
 #      know/care more about the implementation details of types/functions than
 #      should be necessary. For example, `A a; F(std::move(a));` will trigger a
@@ -89,6 +96,8 @@ Checks: >
   -modernize-concat-nested-namespaces,
   -modernize-use-nodiscard,
   -modernize-avoid-c-arrays,
+  -modernize-type-traits,
+  -modernize-unary-static-assert,
   -performance-move-const-arg,
   -performance-avoid-endl,
   -performance-enum-size,

.github/CODEOWNERS

@@ -6,7 +6,7 @@
 * @googleapis/cloud-cxx-owners
 
 # These libraries are also owned by the GCS clients team.
-/google/cloud/storage/ @googleapis/cloud-storage-dpe @googleapis/cloud-cxx-owners
-/google/cloud/storagecontrol/ @googleapis/cloud-storage-dpe @googleapis/cloud-cxx-owners
-/google/cloud/storageinsights/ @googleapis/cloud-storage-dpe @googleapis/cloud-cxx-owners
-/google/cloud/storagetransfer/ @googleapis/cloud-storage-dpe @googleapis/cloud-cxx-owners
+/google/cloud/storage/ @googleapis/gcs-sdk-team @googleapis/cloud-cxx-owners
+/google/cloud/storagecontrol/ @googleapis/gcs-sdk-team @googleapis/cloud-cxx-owners
+/google/cloud/storageinsights/ @googleapis/gcs-sdk-team @googleapis/cloud-cxx-owners
+/google/cloud/storagetransfer/ @googleapis/gcs-sdk-team @googleapis/cloud-cxx-owners

.github/renovate.json

@@ -7,6 +7,7 @@
   "python": {
     "enabled": false
   },
+  "baseBranches": ["main", "/^prepare.*v3/"],
   "regexManagers": [
     {
       "fileMatch": [

.github/workflows/macos-bazel.yml

@@ -25,7 +25,6 @@ jobs:
     runs-on: ${{ matrix.os }}
     permissions:
       contents: 'read'
-      id-token: 'write'
     strategy:
       # Continue other builds even if one fails
       fail-fast: false

.github/workflows/macos-cmake.yml

@@ -33,7 +33,6 @@ jobs:
     runs-on: ${{ matrix.os }}
     permissions:
       contents: 'read'
-      id-token: 'write'
     strategy:
       # Continue other builds even if one fails
       fail-fast: false
@@ -175,7 +174,6 @@ jobs:
           rapidmigrationassessment
           recaptchaenterprise
           recommender
-          resourcesettings
           scheduler
           secretmanager
           securesourcemanager
@@ -264,7 +262,7 @@ jobs:
       if: ${{ inputs.sccache-mode != 'DISABLED' }}
       working-directory: "${{runner.temp}}"
       run: |
-        curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.5.4/sccache-v0.5.4-x86_64-apple-darwin.tar.gz | \
+        curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.9.1/sccache-v0.9.1-x86_64-apple-darwin.tar.gz | \
           tar -zxf - --strip-components=1 && \
         chmod +x sccache && \
         mv sccache /Users/runner/.cargo/bin/sccache

.github/workflows/test-runner.yml

@@ -9,7 +9,7 @@ on:
   # branches we can disable builds (to speed up the testing) or add new ones,
   # without impacting the rest of the team.
   push:
-    branches: [ 'v[2-9]**', 'ci-gha**' ]
+    branches: [ 'v[2-9]**', 'ci-gha**', 'prepare-for-v3.0.0' ]
   # Start the build in the context of the target branch. This is considered
   # "safe", as the workflow files are already committed. These types of builds
   # have access to the secrets in the build, which we need to use the remote
@@ -75,13 +75,6 @@ jobs:
   # in separate files to keep the size of this file under control. Note how
   # the additional jobs inherit any secrets needed to use the remote caches and
   # receive what version to checkout as an input.
-  external-account-integration:
-    name: External Account Integration
-    needs: [pre-flight]
-    uses: ./.github/workflows/external-account-integration.yml
-    with:
-      checkout-ref: ${{ needs.pre-flight.outputs.checkout-sha }}
-    secrets: inherit
   macos-bazel:
     # Build the full matrix only on push events to the default branch, or
     # when PR gets the has a `gha:full-build` label, or when it had the
@@ -160,7 +153,6 @@ jobs:
     name: Notify-Google-Chat
     # Wait until all the other jobs have completed.
     needs:
-      - external-account-integration
       - macos-bazel
       - macos-cmake
       - windows-bazel

.github/workflows/windows-bazel.yml

@@ -25,7 +25,6 @@ jobs:
     runs-on: windows-2022
     permissions:
       contents: 'read'
-      id-token: 'write'
     strategy:
       # Continue other builds even if one fails
       fail-fast: false
@@ -89,6 +88,9 @@ jobs:
     - name: Pre Build Disk Space
       shell: bash
       run: df -m
+    - name: Check installed curl version
+      shell: bash
+      run: curl --version
     - name: Build google-cloud-cpp
       shell: bash
       run: |

.github/workflows/windows-cmake.yml

@@ -33,7 +33,6 @@ jobs:
     runs-on: windows-2022
     permissions:
       contents: 'read'
-      id-token: 'write'
     strategy:
       # Continue other builds even if one fails
       fail-fast: false
@@ -42,7 +41,7 @@ jobs:
         msvc: [ msvc-2022 ]
         build_type: [ Debug, Release ]
         arch: [ x64, x86 ]
-        shard: [Core1, Core2, Core3, Compute, AIPlatform, Shard1, Shard2, Shard3, Other]
+        shard: [Core1, Core2, Core3, Core4, Core5, Compute, AIPlatform, Shard1, Shard2, Shard3, Shard4, Other]
         exclude:
         # Also skip shards (Compute and Other) that contain only generated code.
         - exclude-from-full-trick: ${{ ! inputs.full-matrix }}
@@ -55,11 +54,16 @@ jobs:
           shard: Shard2
         - exclude-from-full-trick: ${{ ! inputs.full-matrix }}
           shard: Shard3
+        - exclude-from-full-trick: ${{ ! inputs.full-matrix }}
+          shard: Shard4
         - exclude-from-full-trick: ${{ ! inputs.full-matrix }}
           shard: Other
         # No need to duplicate testing with x86 mode and Debug mode
         - arch: x86
           build_type: Debug
+        # TODO(#15070): Undo exclusion of the shard if we can reduce PDB size.
+        - shard: Core4
+          build_type: Debug
     steps:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
       with:
@@ -81,9 +85,11 @@ jobs:
       shell: bash
       run: |
         echo "vcpkg-version=$(cat ci/etc/vcpkg-version.txt)" >> "${GITHUB_OUTPUT}"
-        core1_features=(bigtable pubsub pubsublite)
+        core1_features=(bigtable)
         core2_features=(spanner)
-        core3_features=(storage storage_grpc)
+        core3_features=(storage)
+        core4_features=(storage_grpc)
+        core5_features=(pubsub pubsublite)
         # These are the libraries with the most "clients". To build the list
         # run something like this and create shards:
         #
@@ -113,17 +119,6 @@ jobs:
           servicecontrol
           speech
           support
-          video
-          datacatalog
-          iam
-          kms
-          run
-          talent
-          contentwarehouse
-          dataplex
-          bigquery
-          bigquerycontrol
-          resourcemanager
         )
         shard3_features=(
           securesourcemanager
@@ -170,6 +165,58 @@ jobs:
           vision
           workflows
         )
+        shard4_features=(
+          accessapproval
+          accesscontextmanager
+          advisorynotifications
+          alloydb
+          apigateway
+          apigeeconnect
+          apikeys
+          apphub
+          artifactregistry
+          assuredworkloads
+          backupdr
+          baremetalsolution
+          batch
+          certificatemanager
+          cloudquotas
+          commerce
+          confidentialcomputing
+          config
+          connectors
+          contactcenterinsights
+          container
+          datafusion
+          datamigration
+          datastream
+          deploy
+          developerconnect
+          dlp
+          documentai
+          domains
+          edgecontainer
+          edgenetwork
+          essentialcontacts
+          filestore
+          financialservices
+          gkebackup
+          gkeconnect
+          gkehub
+        )
+        shard5_features=(
+          video
+          datacatalog
+          iam
+          kms
+          run
+          talent
+          contentwarehouse
+          dataplex
+          bigquery
+          bigquerycontrol
+          resourcemanager
+        )
         if [[ "${{ matrix.shard }}" == "Core1" ]]; then
           features="$(printf ",%s" "${core1_features[@]}")"
           echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
@@ -179,6 +226,12 @@ jobs:
         elif [[ "${{ matrix.shard }}" == "Core3" ]]; then
           features="$(printf ",%s" "${core3_features[@]}")"
           echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
+        elif [[ "${{ matrix.shard }}" == "Core4" ]]; then
+          features="$(printf ",%s" "${core4_features[@]}")"
+          echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
+        elif [[ "${{ matrix.shard }}" == "Core5" ]]; then
+          features="$(printf ",%s" "${core5_features[@]}")"
+          echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
         elif [[ "${{matrix.shard}}" == "Compute" ]]; then
           echo "features=compute" >> "${GITHUB_OUTPUT}"
         elif [[ "${{matrix.shard}}" == "AIPlatform" ]]; then
@@ -192,15 +245,25 @@ jobs:
         elif [[ "${{matrix.shard}}" == "Shard3" ]]; then
           features="$(printf ",%s" "${shard3_features[@]}")"
           echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
+        elif [[ "${{matrix.shard}}" == "Shard4" ]]; then
+          features="$(printf ",%s" "${shard4_features[@]}")"
+          echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
+        elif [[ "${{matrix.shard}}" == "Shard5" ]]; then
+          features="$(printf ",%s" "${shard5_features[@]}")"
+          echo "features=${features:1}" >> "${GITHUB_OUTPUT}"
         else
           skipped_features=("${core1_features[@]}")
           skipped_features+=("${core2_features[@]}")
           skipped_features+=("${core3_features[@]}")
+          skipped_features+=("${core4_features[@]}")
+          skipped_features+=("${core5_features[@]}")
           skipped_features+=(compute)
           skipped_features+=(aiplatform)
           skipped_features+=("${shard1_features[@]}")
           skipped_features+=("${shard2_features[@]}")
           skipped_features+=("${shard3_features[@]}")
+          skipped_features+=("${shard4_features[@]}")
+          skipped_features+=("${shard5_features[@]}")
           # We use vcpkg in this build, which ships with Protobuf v21.x.
           # Both `asset` and `channel` require Protobuf >= 23.x to compile on
           # Windows.
@@ -211,12 +274,19 @@ jobs:
     - name: Pre Build Disk Space
       shell: bash
       run: df -m
+    - name: Download and Install CMake
+      shell: bash
+      run: |
+        choco install -y --allow-downgrade cmake --version 3.31.6 || \
+        (sleep 60  ; choco install -y --allow-downgrade cmake --version 3.31.6) || \
+        (sleep 120 ; choco install -y --allow-downgrade cmake --version 3.31.6)
     - name: Download and Install sccache
       if: ${{ inputs.sccache-mode != 'DISABLED' }}
       working-directory: "${{runner.temp}}"
       shell: bash
       run: |
-        curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.5.4/sccache-v0.5.4-x86_64-pc-windows-msvc.tar.gz | \
+        mkdir -p /c/Users/runneradmin/.cargo/bin
+        curl -fsSL https://github.com/mozilla/sccache/releases/download/v0.9.1/sccache-v0.9.1-x86_64-pc-windows-msvc.tar.gz | \
           tar -zxf - --strip-components=1
         chmod +x sccache.exe
         mv sccache.exe /c/Users/runneradmin/.cargo/bin

BUILD.bazel

@@ -150,7 +150,6 @@ cc_library(
 bool_flag(
     name = "enable-ctype-cord-workaround",
     build_setting_default = False,
-    visibility = ["//:__subpackages__"],
 )
 
 cc_library(
@@ -259,5 +258,4 @@ cc_library(
 bool_flag(
     name = "enable_opentelemetry",
     build_setting_default = False,
-    visibility = ["//:__subpackages__"],
 )