fix: emulator: fix MSVC compilation error due to storing a int64_t in a size_t.

marete · web-flow · commit 173f00beb4d4 · 2025-07-11T11:23:57.000+03:00
The compiler spits out an error in pedantic mode because on 32 bit platforms, there is a usually the possibility of an overflow. However, the quantity is guaranteed to be 32 bit (https://github.com/googleapis/googleapis/blob/74657e8a6690b249c048f685124ee3b8473b70b4/google/bigtable/v2/data.proto#L497) so use int32_t to store it and fix the MSVC compiler warning and failure.
diff --git a/google/cloud/bigtable/emulator/filter.cc b/google/cloud/bigtable/emulator/filter.cc
@@ -919,7 +919,7 @@ StatusOr<CellStreamConstructor> CreateFilterImpl(
     return res;
   }
   if (filter.has_cells_per_column_limit_filter()) {
-    std::int64_t cells_per_column_limit =
+    std::int32_t cells_per_column_limit =
         filter.cells_per_column_limit_filter();
     if (cells_per_column_limit < 0) {
       return InvalidArgumentError(

Original file line number	Diff line number	Diff line change
`@@ -919,7 +919,7 @@ StatusOr<CellStreamConstructor> CreateFilterImpl(`
`919`	`919`	`return res;`
`920`	`920`	`}`
`921`	`921`	`if (filter.has_cells_per_column_limit_filter()) {`
`922`		`- std::int64_t cells_per_column_limit =`
	`922`	`+ std::int32_t cells_per_column_limit =`
`923`	`923`	`filter.cells_per_column_limit_filter();`
`924`	`924`	`if (cells_per_column_limit < 0) {`
`925`	`925`	`return InvalidArgumentError(`