Skip to content

Commit 326f955

Browse files
committed
cleanup
1 parent d47f0be commit 326f955

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

ci/kokoro/lib/vcpkg.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,11 @@ install_vcpkg() {
3232
io::log "Downloading vcpkg into ${vcpkg_dir}..."
3333
VCPKG_VERSION="$(<ci/etc/vcpkg-version.txt)"
3434
url="https://github.com/microsoft/vcpkg/archive/${VCPKG_VERSION}.tar.gz"
35-
# if [[ "${VCPKG_VERSION}" =~ [0-9]{4}.[0-9]{2}.[0-9]{2} ]]; then
36-
# # vcpkg uses date-like tags for releases
37-
# url="https://github.com/microsoft/vcpkg/archive/refs/tags/${VCPKG_VERSION}.tar.gz"
38-
# fi
35+
# TODO(#15942): Figure out why this check isn't working.
36+
# if [[ "${VCPKG_VERSION}" =~ [0-9]{4}.[0-9]{2}.[0-9]{2} ]]; then
37+
# # vcpkg uses date-like tags for releases
38+
# url="https://github.com/microsoft/vcpkg/archive/refs/tags/${VCPKG_VERSION}.tar.gz"
39+
# fi
3940
ci/retry-command.sh 3 120 curl -fsSL "${url}" |
4041
tar -C "${vcpkg_dir}" --strip-components=1 -zxf -
4142

ci/kokoro/windows/build.bat

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ REM Configure the environment to use MSVC %MSVC_VERSION% and then switch to Powe
2121
call "%ProgramFiles(x86)%\Microsoft Visual Studio\%MSVC_VERSION%\BuildTools\VC\Auxiliary\Build\vcvars64.bat"
2222
set "BAZEL_VC=%ProgramFiles(x86)%\Microsoft Visual Studio\%MSVC_VERSION%\BuildTools\VC"
2323
set "VCPKG_OVERLAY_TRIPLETS=%cd%\ci\kokoro\windows\triplets"
24-
@REM set "VCPKG_OVERLAY_PORTS=%cd%\ci\kokoro\windows\vcpkg-overlays"
2524

2625
REM The remaining of the build script is implemented in PowerShell.
2726
@echo %date% %time%

ci/kokoro/windows/lib/vcpkg.ps1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ function Install-Vcpkg {
6969

7070
$vcpkg_version = Get-Content -Path "${project_root}\ci\etc\vcpkg-version.txt"
7171
$vcpkg_url = "https://github.com/microsoft/vcpkg/archive/${vcpkg_version}.zip"
72+
# TODO(#15942): Figure out why this check isn't working.
7273
# if ($vcpkg_version -match "[0-9]{4}.[0-9]{2}.[0-9]{2}" ) {
7374
# $vcpkg_url = "https://github.com/microsoft/vcpkg/archive/refs/tags/${vcpkg_version}.zip"
7475
# }

0 commit comments

Comments
 (0)