Add check for writeHandle before reansforming write_object_spec to append_object_spec

Author: v-pratap

google/cloud/storage/internal/async/handle_redirect_error.cc

@@ -23,10 +23,10 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 void EnsureFirstMessageAppendObjectSpec(
     google::storage::v2::BidiWriteObjectRequest& request,
     google::rpc::Status const& rpc_status) {
-  for (auto const& rpc_status_detail : rpc_status.details()) {
+  for (auto const& any : rpc_status.details()) {
     google::storage::v2::BidiWriteObjectRedirectedError error =
         google::storage::v2::BidiWriteObjectRedirectedError{};
-    if (!rpc_status_detail.UnpackTo(&error)) continue;
+    if (!any.UnpackTo(&error)) continue;
     if (!error.has_write_handle()) continue;
     if (request.has_write_object_spec()) {
       auto spec = request.write_object_spec();

google/cloud/storage/internal/async/handle_redirect_error_test.cc

@@ -75,7 +75,7 @@ TEST(EnsureFirstMessageAppendObjectSpec, Success) {
   ASSERT_TRUE(google::protobuf::TextFormat::ParseFromString(
       R"pb(
         write_object_spec {
-          resource { bucket: "projects/_/buckets/b", name: "o" }
+          resource { bucket: "projects/_/buckets/b", name: "o"  }
           if_metageneration_match: 1
           if_metageneration_not_match: 1
         }
@@ -124,6 +124,8 @@ TEST(EnsureFirstMessageAppendObjectSpec, WriteHandleIsNotSet) {
   EXPECT_FALSE(request.has_append_object_spec());
 }
 
+
+
 }  // namespace
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace storage_internal

google/cloud/storage/internal/async/writer_connection_impl.cc

@@ -234,7 +234,8 @@ future<StatusOr<std::int64_t>> AsyncWriterConnectionImpl::OnQuery(
             "Expected error in Finish() after non-ok Read()"))
         .then([this](auto g) {
           auto result = g.get();
-          google::rpc::Status grpc_status = ExtractGrpcStatus(result);
+          google::rpc::Status grpc_status =
+                  ExtractGrpcStatus(result);
           EnsureFirstMessageAppendObjectSpec(request_, grpc_status);
           ApplyWriteRedirectErrors(*request_.mutable_append_object_spec(),
                                    grpc_status);