Merge branch 'main' into fix-billing-quickstart-docs

Author: scotthart

.bazelrc

@@ -18,14 +18,16 @@
 # Use host-OS-specific config lines from bazelrc files.
 build --enable_platform_specific_config=true
 
-# The project requires C++ >= 14. By default Bazel adds `-std=c++0x` which
-# disables C++14 features, even if the compilers defaults to C++ >= 14
-build:linux --cxxopt=-std=c++14
-build:macos --cxxopt=-std=c++14
-# Protobuf and gRPC require (or soon will require) C++14 to compile the "host"
+build --features=external_include_paths
+build --cxxopt=-Wno-private-header
+
+# The project requires C++ >= 17.
+build:linux --cxxopt=-std=c++17
+build:macos --cxxopt=-std=c++17
+# Protobuf and gRPC require C++17 to compile the "host"
 # targets, such as protoc and the grpc plugin.
-build:linux --host_cxxopt=-std=c++14
-build:macos --host_cxxopt=-std=c++14
+build:linux --host_cxxopt=-std=c++17
+build:macos --host_cxxopt=-std=c++17
 
 # Do not create the convenience links. They are inconvenient when the build
 # runs inside a docker image or if one builds a quickstart and then builds
@@ -47,9 +49,6 @@ build --experimental_ui_max_stdouterr_bytes=-1
 # in a random order to help expose undesirable interdependencies.
 test --test_env=GTEST_SHUFFLE --test_env=GTEST_RANDOM_SEED
 
-# By default, build the library with OpenTelemetry
-build --//:enable_opentelemetry
-
 # Don't show warnings when building external dependencies. This still shows
 # warnings when using these dependencies (say in headers).
 build --output_filter='^//((?!(external):).)*$'
@@ -70,6 +69,8 @@ build:sanitizer --strip=never
 build:sanitizer --copt=-Og
 build:sanitizer --copt=-g
 build:sanitizer --copt=-fno-omit-frame-pointer
+#build:sanitizer --features=external_include_paths
+
 
 # --config asan: Address Sanitizer
 build:asan --config=sanitizer
@@ -102,6 +103,8 @@ build:ubsan --copt=-DCURL_STRICTER
 build:ubsan --linkopt=-fsanitize=undefined
 build:ubsan --linkopt=-fsanitize-link-c++-runtime
 build:ubsan --action_env=UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1
+#build:ubsan --features=external_include_paths
+
 
 # --config xsan: Runs misc. sanitizers that aren't covered elsewhere.
 build:xsan --config=sanitizer
@@ -128,3 +131,4 @@ build:msan --linkopt=-L/usr/lib/x86_64-unknown-linux-gnu
 
 # --config otel2: Open Telemetery ABI version 2
 build:otel2 --cxxopt=-DOPENTELEMETRY_ABI_VERSION_NO=2
+build:otel2 --@opentelemetry-cpp//api:abi_version_no=2

.bazelversion

@@ -1 +1 @@
-7.6.1
+8.4.2

.clang-tidy

@@ -85,6 +85,7 @@ Checks: >
   performance-*,
   portability-*,
   readability-*,
+  -bugprone-exception-escape,
   -google-readability-braces-around-statements,
   -google-readability-namespace-comments,
   -google-runtime-references,

.github/CODEOWNERS

@@ -6,7 +6,7 @@
 * @googleapis/cloud-sdk-cpp-team
 
 # These libraries are also owned by the GCS clients team.
-/google/cloud/storage/ @googleapis/gcs-sdk-team @googleapis/cloud-sdk-cpp-team
-/google/cloud/storagecontrol/ @googleapis/gcs-sdk-team @googleapis/cloud-sdk-cpp-team
-/google/cloud/storageinsights/ @googleapis/gcs-sdk-team @googleapis/cloud-sdk-cpp-team
-/google/cloud/storagetransfer/ @googleapis/gcs-sdk-team @googleapis/cloud-sdk-cpp-team
+/google/cloud/storage/ @googleapis/gcs-team @googleapis/cloud-sdk-cpp-team
+/google/cloud/storagecontrol/ @googleapis/gcs-team @googleapis/cloud-sdk-cpp-team
+/google/cloud/storageinsights/ @googleapis/gcs-team @googleapis/cloud-sdk-cpp-team
+/google/cloud/storagetransfer/ @googleapis/gcs-team @googleapis/cloud-sdk-cpp-team

.github/renovate.json

@@ -7,7 +7,7 @@
   "python": {
     "enabled": false
   },
-  "baseBranches": ["main", "/^prepare.*v3/"],
+  "baseBranches": ["main"],
   "regexManagers": [
     {
       "fileMatch": [
@@ -90,6 +90,7 @@
   ],
   "ignoreDeps": [
     "boringssl",
-    "com_google_googleapis"
+    "com_google_googleapis",
+    "googleapis"
   ]
 }

.github/workflows/codeql-analysis.yml

@@ -22,9 +22,9 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+        uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
       - name: Checkout vcpkg
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+        uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
         with:
           path: "build/vcpkg"
           repository: "microsoft/vcpkg"

.github/workflows/external-account-integration.yml

@@ -26,7 +26,7 @@ jobs:
       id-token: write
 
     steps:
-    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+    - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
       with:
         ref: ${{ inputs.checkout-ref }}
     - id: auth
@@ -56,9 +56,11 @@ jobs:
       working-directory: "${{runner.temp}}"
       run: |
         mkdir -p vcpkg
-        curl -fsSL "https://github.com/microsoft/vcpkg/archive/${{ steps.vcpkg-version.outputs.version }}.tar.gz" |
+        curl -fsSL "https://github.com/microsoft/vcpkg/archive/${STEPS_VCPKG_VERSION_OUTPUTS_VERSION}.tar.gz" |
             tar -C vcpkg --strip-components=1 -zxf -
         vcpkg/bootstrap-vcpkg.sh -disableMetrics
+      env:
+        STEPS_VCPKG_VERSION_OUTPUTS_VERSION: ${{ steps.vcpkg-version.outputs.version }}
     # First compile the code using the identity with access to the build cache
     - run: |
         env VCPKG_ROOT="${{ runner.temp }}/vcpkg" ci/gha/builds/external-account.sh

.github/workflows/macos-cmake.yml

@@ -59,7 +59,7 @@ jobs:
         - exclude-from-full-trick: ${{ ! inputs.full-matrix }}
           shard: Other
     steps:
-    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+    - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5
       with:
         ref: ${{ inputs.checkout-ref }}
     - uses: google-github-actions/auth@v2
@@ -70,7 +70,7 @@ jobs:
     - uses: actions/setup-python@v5
       id: py311
       with:
-        python-version: '3.11'
+        python-version: '3.13'
     - uses: google-github-actions/setup-gcloud@v2
       env:
         CLOUDSDK_PYTHON: ${{ steps.py311.outputs.python-path }}
@@ -84,8 +84,6 @@ jobs:
           spanner
         )
         core2_features=(
-          pubsub
-          pubsublite
           storage
           storage_grpc
         )

.github/workflows/test-runner.yml

@@ -9,7 +9,7 @@ on:
   # branches we can disable builds (to speed up the testing) or add new ones,
   # without impacting the rest of the team.
   push:
-    branches: [ 'ci-gha**', 'prepare-for-v3.0.0' ]
+    branches: [ 'ci-gha**', 'main' ]
   # Start the build in the context of the target branch. This is considered
   # "safe", as the workflow files are already committed. These types of builds
   # have access to the secrets in the build, which we need to use the remote
@@ -30,19 +30,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  debug:
-    name: debug_job
-    runs-on: ubuntu-latest
-    steps:
-      - name: debug_steps
-        id: debug-steps
-        run: |
-          echo "event=${{ github.event_name }}"
-          echo "assoc=${{ github.event.pull_request.author_association }}"
-          echo "org=${{ github.organization }}" || true
-          echo "user=${{ github.event.pull_request.user }}" || true
-          echo "user_orgs=${{ github.event.pull_request.user.organizations_url }}" || true
-
   pre-flight:
     # Save the `ref` of the pull request, so downstream jobs know what to checkout.
     environment: >-
@@ -51,7 +38,6 @@ jobs:
           (github.event.pull_request.head.repo.full_name == github.repository && 'internal')
       }}
     name: Save PR ref
-    needs: [debug]
     if: >-
       ${{
           ((github.event.pull_request.author_association == 'OWNER' ||
@@ -120,6 +106,8 @@ jobs:
       execute-integration-tests: true
     secrets: inherit
   windows-cmake:
+    # Disabled
+    if: false
     name: Windows-CMake
     needs: [pre-flight]
     uses: ./.github/workflows/windows-cmake.yml

.github/workflows/windows-bazel.yml

@@ -70,9 +70,11 @@ jobs:
         # Using a short name like this avoids the problem in most cases.
         mkdir -p 'c:\b' || true
         export BAZEL_ROOT='c:\b'
-        export BAZEL_REMOTE_CACHE_RW_MODE=${{ inputs.bazel-cache-mode }}
+        export BAZEL_REMOTE_CACHE_RW_MODE=${INPUTS_BAZEL_CACHE_MODE}
         export EXECUTE_INTEGRATION_TESTS=${{ inputs.execute-integration-tests }}
         ci/gha/builds/windows-bazel.sh ${{ matrix.compilation_mode }} ${{ join(matrix.targets, ' ') }}
+      env:
+        INPUTS_BAZEL_CACHE_MODE: ${{ inputs.bazel-cache-mode }}
     - name: Post Build Disk Space
       shell: bash
       run: df -m