Skip to content

Commit 54b6476

Browse files
authored
impl(v3): Multiplexed sessions always enabled (#15941)
1 parent 3cf9e93 commit 54b6476

43 files changed

Lines changed: 473 additions & 1541 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

doc/v3-migration-guide.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,21 @@ auto subscriber = pubsub::Subscriber(pubsub::MakeSubscriberConnection(
737737
738738
### Spanner
739739
740+
<details>
741+
<summary>All sessions are now Multiplexed Sessions</summary>
742+
743+
All SessionPool related options are marked deprecated and are now ignored by the
744+
Spanner library and will be removed in the future:
745+
746+
- `EnableMultiplexedSessionOption`
747+
- `SessionPoolMinSessionsOption`
748+
- `SessionPoolMaxSessionsPerChannelOption`
749+
- `SessionPoolMaxIdleSessionsOption`
750+
- `SessionPoolActionOnExhaustionOption`
751+
- `SessionPoolKeepAliveIntervalOption`
752+
753+
</details>
754+
740755
<details>
741756
<summary>Removed <code>spanner::MakeTestRow</code>
742757
</summary>

google/cloud/spanner/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ this library.
1818
<!-- inject-quickstart-start -->
1919

2020
```cc
21+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
22+
2123
#include "google/cloud/spanner/client.h"
2224
#include <iostream>
2325

@@ -45,6 +47,7 @@ int main(int argc, char* argv[]) {
4547

4648
return 0;
4749
}
50+
#include "google/cloud/internal/diagnostics_pop.inc"
4851
```
4952
5053
<!-- inject-quickstart-end -->

google/cloud/spanner/admin/integration_tests/backup_extra_integration_test.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/admin/database_admin_client.h"
1616
#include "google/cloud/spanner/admin/database_admin_options.h"
1717
#include "google/cloud/spanner/admin/instance_admin_client.h"
@@ -541,3 +541,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
541541
} // namespace spanner
542542
} // namespace cloud
543543
} // namespace google
544+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/admin/integration_tests/backup_integration_test.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/admin/database_admin_client.h"
1616
#include "google/cloud/spanner/admin/database_admin_options.h"
1717
#include "google/cloud/spanner/backoff_policy.h"
@@ -275,3 +275,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
275275
} // namespace spanner
276276
} // namespace cloud
277277
} // namespace google
278+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/admin/database_admin_client.h"
1616
#include "google/cloud/spanner/benchmarks/benchmarks_config.h"
1717
#include "google/cloud/spanner/client.h"
@@ -1434,3 +1434,4 @@ int main(int argc, char* argv[]) {
14341434
: "database dropped\n");
14351435
return exit_status;
14361436
}
1437+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/admin/database_admin_client.h"
1616
#include "google/cloud/spanner/benchmarks/benchmarks_config.h"
1717
#include "google/cloud/spanner/client.h"
@@ -511,3 +511,4 @@ int main(int argc, char* argv[]) {
511511
: "database dropped\n");
512512
return 0;
513513
}
514+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/client.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/client.h"
1616
#include "google/cloud/spanner/internal/connection_impl.h"
1717
#include "google/cloud/spanner/internal/spanner_stub_factory.h"
@@ -432,3 +432,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
432432
} // namespace spanner
433433
} // namespace cloud
434434
} // namespace google
435+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/client_test.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/client.h"
1616
#include "google/cloud/mocks/mock_stream_range.h"
1717
#include "google/cloud/spanner/connection.h"
@@ -1339,3 +1339,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
13391339
} // namespace spanner
13401340
} // namespace cloud
13411341
} // namespace google
1342+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/commit_options.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/commit_options.h"
1616
#include "google/cloud/spanner/options.h"
1717

@@ -48,3 +48,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
4848
} // namespace spanner
4949
} // namespace cloud
5050
} // namespace google
51+
#include "google/cloud/internal/diagnostics_pop.inc"

google/cloud/spanner/connection.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
14-
14+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1515
#include "google/cloud/spanner/connection.h"
1616
#include "google/cloud/spanner/query_partition.h"
1717
#include "google/cloud/spanner/read_partition.h"
@@ -115,3 +115,4 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
115115
} // namespace spanner
116116
} // namespace cloud
117117
} // namespace google
118+
#include "google/cloud/internal/diagnostics_pop.inc"

0 commit comments

Comments
 (0)