Skip to content

Commit 58ed587

Browse files
committed
address review comments
1 parent fc08621 commit 58ed587

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

doc/v3-migration-guide.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ for your compiler if it does not already default to `--std=c++17` or higher.
2727

2828
### Relocated Dependencies
2929

30-
- `crc32c` Is now distributed as part of Abseil.
30+
- `crc32c` google-cloud-cpp now uses the crc32c implementation in Abseil.
3131

3232
## Build system changes
3333

@@ -41,6 +41,10 @@ Central Registry. Part of the v3.x.y release series includes supporting the new
4141
[google-cloud-cpp](https://registry.bazel.build/modules/google_cloud_cpp) Bazel
4242
module which can be added to your `MODULE.bazel` file as a dependency.
4343

44+
google-cloud-cpp will support WORKSPACE files until Bazel 8 reaches end of
45+
support (2027/12). However, some dependencies may stop supporting WORKSPACE
46+
files before then which will limit what dependency versions can be used via
47+
WORKSPACE.
4448
</details>
4549

4650
### CMake
@@ -49,8 +53,8 @@ module which can be added to your `MODULE.bazel` file as a dependency.
4953
<summary>Removed backward compatible proto interface libraries.</summary>
5054

5155
If your application links directly to one of these decommissioned proto
52-
libraries, the CMakeLists.txt should be updated with the preferred proto library
53-
name.
56+
libraries, your CMakeLists.txt should be updated with the preferred proto
57+
library name.
5458

5559
| Library | Decommissioned Proto Library | Preferred Proto Library |
5660
| -------------------------- | ------------------------------------- | -------------------------------------- |
@@ -340,7 +344,7 @@ for (auto& row : table.ReadRows(
340344
</summary>
341345
#### `bigtable::ClientOptions`
342346
343-
The deprecated `bigtable::ClientOptions` has been removed. Please use
347+
We have removed the deprecated `bigtable::ClientOptions` class. Please use
344348
`google::cloud::Options` instead.
345349
346350
The following table shows the mapping from `bigtable::ClientOptions` methods to
@@ -496,8 +500,7 @@ auto options = google::cloud::Options{}.set<google::cloud::EndpointOption>("..."
496500
The `bigtable::DataClient` class and its associated factory functions (e.g.,
497501
`MakeDataClient`) have been removed. Applications should now use
498502
`bigtable::DataConnection` and `bigtable::MakeDataConnection()` instead. For
499-
detailed migration steps and examples, please refer to the official migration
500-
guide:
503+
detailed migration steps and examples, please refer to the migration guide:
501504

502505
[Migrating from DataClient to DataConnection](https://docs.cloud.google.com/cpp/docs/reference/bigtable/latest/migrating-from-dataclient)
503506

0 commit comments

Comments
 (0)