resolving comments

Author: shubham-up-47

google/cloud/opentelemetry/quickstart/quickstart.cc

@@ -63,4 +63,4 @@ int main(int argc, char* argv[]) {
 
   return 0;
 }
-//! [all] [END storage_enable_otel_tracing]
+//! [all] [END storage_enable_otel_tracing]

google/cloud/storage/client.cc

@@ -127,6 +127,21 @@ bool Client::UseSimpleUpload(std::string const& file_name, std::size_t& size) {
   return false;
 }
 
+StatusOr<ObjectMetadata> Client::UploadFileSimple(
+    std::string const& file_name, std::size_t file_size,
+    internal::InsertObjectMediaRequest& request) {
+  auto status = connection_->UploadFileSimple(file_name, file_size, request);
+  if (!status) return status.status();
+  return connection_->InsertObjectMedia(request);
+}
+
+StatusOr<ObjectMetadata> Client::UploadFileResumable(
+    std::string const& file_name, internal::ResumableUploadRequest& request) {
+  auto source = connection_->UploadFileResumable(file_name, request);
+  if (!source) return source.status();
+  return UploadStreamResumable(*source.value(), request);
+}
+
 StatusOr<ObjectMetadata> Client::UploadStreamResumable(
     std::istream& source,
     internal::ResumableUploadRequest const& request) const {

google/cloud/storage/client.h

@@ -3511,9 +3511,7 @@ class Client {
         SpanOptions(std::forward<Options>(options)...));
     internal::ResumableUploadRequest request(bucket_name, object_name);
     request.set_multiple_options(std::forward<Options>(options)...);
-    auto source = connection_->UploadFileResumable(file_name, request);
-    if (!source) return source.status();
-    return UploadStreamResumable(*source.value(), request);
+    return UploadFileResumable(file_name, request);
   }
 
   // The version of UploadFile() where UseResumableUploadSession is *not* one of
@@ -3532,19 +3530,22 @@ class Client {
       internal::InsertObjectMediaRequest request(bucket_name, object_name,
                                                  std::string{});
       request.set_multiple_options(std::forward<Options>(options)...);
-      auto status = connection_->UploadFileSimple(file_name, file_size, request);
-      if (!status) return status.status();
-      return connection_->InsertObjectMedia(request);
+      return UploadFileSimple(file_name, file_size, request);
     }
     internal::ResumableUploadRequest request(bucket_name, object_name);
     request.set_multiple_options(std::forward<Options>(options)...);
-    auto source = connection_->UploadFileResumable(file_name, request);
-    if (!source) return source.status();
-    return UploadStreamResumable(*source.value(), request);
+    return UploadFileResumable(file_name, request);
   }
 
   static bool UseSimpleUpload(std::string const& file_name, std::size_t& size);
 
+  StatusOr<ObjectMetadata> UploadFileSimple(
+      std::string const& file_name, std::size_t file_size,
+      internal::InsertObjectMediaRequest request);
+
+  StatusOr<ObjectMetadata> UploadFileResumable(
+      std::string const& file_name, internal::ResumableUploadRequest request);
+
   StatusOr<ObjectMetadata> UploadStreamResumable(
       std::istream& source,
       internal::ResumableUploadRequest const& request) const;

google/cloud/storage/internal/connection_impl.cc

@@ -801,8 +801,9 @@ StatusOr<EmptyResponse> StorageConnectionImpl::UploadFileSimple(
   return EmptyResponse();
 }
 
-StatusOr<std::unique_ptr<std::istream>> StorageConnectionImpl::UploadFileResumable(
-    std::string const& file_name, ResumableUploadRequest& request) {
+StatusOr<std::unique_ptr<std::istream>>
+StorageConnectionImpl::UploadFileResumable(std::string const& file_name,
+                                           ResumableUploadRequest& request) {
   auto upload_offset = request.GetOption<UploadFromOffset>().value_or(0);
   auto status = google::cloud::internal::status(file_name);
   if (!is_regular(status)) {

google/cloud/storage/internal/storage_connection.h

@@ -112,10 +112,14 @@ class StorageConnection {
       UploadChunkRequest const& request) = 0;
   virtual StatusOr<EmptyResponse> UploadFileSimple(
       std::string const& file_name, std::size_t file_size,
-      InsertObjectMediaRequest& request) = 0;
+      InsertObjectMediaRequest& request) {
+    return Status(StatusCode::kUnimplemented, "unimplemented");
+  }
   virtual StatusOr<std::unique_ptr<std::istream>> UploadFileResumable(
       std::string const& file_name,
-      ResumableUploadRequest& request) = 0;
+      ResumableUploadRequest& request) {
+    return Status(StatusCode::kUnimplemented, "unimplemented");
+  }
   ///@}
 
   ///@{