Skip to content

Commit 9c4d070

Browse files
committed
address review comments
1 parent 4503dec commit 9c4d070

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

ci/showcase/grpc_pqc_test.cc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,15 @@ class HeaderInterceptingEchoStub : public v1beta1_internal::EchoStub {
179179

180180
private:
181181
void ExtractMetadata(grpc::ClientContext& context) {
182+
auto to_string = [](grpc::string_ref ref) {
183+
return ref.empty() ? std::string{} : std::string{ref.data(), ref.size()};
184+
};
182185
std::multimap<std::string, std::string> metadata;
183186
for (auto const& pair : context.GetServerInitialMetadata()) {
184-
metadata.emplace(std::string(pair.first.data(), pair.first.size()),
185-
std::string(pair.second.data(), pair.second.size()));
187+
metadata.emplace(to_string(pair.first), to_string(pair.second));
186188
}
187189
for (auto const& pair : context.GetServerTrailingMetadata()) {
188-
metadata.emplace(std::string(pair.first.data(), pair.first.size()),
189-
std::string(pair.second.data(), pair.second.size()));
190+
metadata.emplace(to_string(pair.first), to_string(pair.second));
190191
}
191192
metadata_callback_(metadata);
192193
}

0 commit comments

Comments
 (0)