remove extra scope in lieu of proper var order

Author: scotthart

google/cloud/spanner/internal/connection_impl_test.cc

@@ -3262,18 +3262,17 @@ TEST(ConnectionImplTest, CommitSuccessExcludeFromChangeStreamsExplicitTxn) {
       MakeLimitedTimeOptions()
           .set<spanner::ExcludeTransactionFromChangeStreamsOption>(true));
 
-  // Introduce additional scope here to ensure that when txn is destroyed
-  // the session_pool contained by the Connection is still present, such that,
-  // the session associated with the transaction can be returned to the pool.
-  {
-    auto txn = spanner::Transaction(spanner::Transaction::ReadWriteOptions{});
-    auto commit = conn->Commit({txn, {}});
-    EXPECT_THAT(
-        commit,
-        IsOkAndHolds(Field(
-            &spanner::CommitResult::commit_timestamp,
-            Eq(spanner::MakeTimestamp(absl::FromUnixSeconds(123)).value()))));
-  }
+  // Make sure we create the Transaction after the Connection to ensure that
+  // when txn is destroyed the session_pool contained by the Connection is still
+  // present, such that, the session associated with the transaction can be
+  // returned to the pool.
+  auto txn = spanner::Transaction(spanner::Transaction::ReadWriteOptions{});
+  auto commit = conn->Commit({txn, {}});
+  EXPECT_THAT(
+      commit,
+      IsOkAndHolds(Field(
+          &spanner::CommitResult::commit_timestamp,
+          Eq(spanner::MakeTimestamp(absl::FromUnixSeconds(123)).value()))));
 }
 
 TEST(ConnectionImplTest, CommitSuccessWithMaxCommitDelay) {