Skip to content

Commit b2af84c

Browse files
committed
Manually update READMEs, quickstart, and top-level stuff
1 parent 8fc951e commit b2af84c

11 files changed

Lines changed: 40 additions & 28 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ breaking changes in the upcoming 3.x release. This release is scheduled for
66

77
## v2.40.0 - TBD
88

9+
### Updated Libraries
10+
11+
- [ManagedKafka](/google/cloud/managedkafka/README.md) - add schemaregistry to the library
12+
913
## v2.39.0 - 2025-07
1014

1115
### [Storage](/google/cloud/storage/README.md)

google/cloud/managedkafka/BUILD.bazel

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -18,10 +18,14 @@ package(default_visibility = ["//visibility:private"])
1818

1919
licenses(["notice"]) # Apache 2.0
2020

21-
service_dirs = ["schemaregistry/v1/"]
21+
service_dirs = [
22+
"v1/",
23+
"schemaregistry/v1/",
24+
]
2225

2326
googleapis_deps = [
24-
"@com_google_googleapis//google/cloud/managedkafka/schemaregistry/v1:managedkafka_cc_grpc",
27+
"@com_google_googleapis//google/cloud/managedkafka/v1:managedkafka_cc_grpc",
28+
"@com_google_googleapis//google/cloud/managedkafka/schemaregistry/v1:schemaregistry_cc_grpc"
2529
]
2630

2731
cc_gapic_library(

google/cloud/managedkafka/CMakeLists.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ~~~
2-
# Copyright 2025 Google LLC
2+
# Copyright 2024 Google LLC
33
#
44
# Licensed under the Apache License, Version 2.0 (the "License");
55
# you may not use this file except in compliance with the License.
@@ -18,7 +18,7 @@ include(GoogleCloudCppLibrary)
1818

1919
google_cloud_cpp_add_gapic_library(
2020
managedkafka "Managed Service for Apache Kafka API"
21-
SERVICE_DIRS "schemaregistry/v1/")
21+
SERVICE_DIRS "v1/" "schemaregistry/v1/")
2222

2323
if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
2424
add_executable(managedkafka_quickstart "quickstart/quickstart.cc")
@@ -30,8 +30,7 @@ if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
3030
COMMAND
3131
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
3232
$<TARGET_FILE:managedkafka_quickstart> GOOGLE_CLOUD_PROJECT
33-
GOOGLE_CLOUD_CPP_TEST_REGION # EDIT HERE
34-
)
33+
GOOGLE_CLOUD_CPP_TEST_REGION)
3534
set_tests_properties(managedkafka_quickstart
3635
PROPERTIES LABELS "integration-test;quickstart")
3736
endif ()

google/cloud/managedkafka/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ this library.
1818
<!-- inject-quickstart-start -->
1919

2020
```cc
21-
#include "google/cloud/managedkafka/schemaregistry/v1/ EDIT HERE _client.h"
21+
#include "google/cloud/managedkafka/v1/managed_kafka_client.h"
2222
#include "google/cloud/location.h"
2323
#include <iostream>
2424

@@ -30,11 +30,11 @@ int main(int argc, char* argv[]) try {
3030

3131
auto const location = google::cloud::Location(argv[1], argv[2]);
3232

33-
namespace managedkafka = ::google::cloud::managedkafka_schemaregistry_v1;
34-
auto client = managedkafka::ServiceClient(
35-
managedkafka::MakeServiceConnection()); // EDIT HERE
33+
namespace managedkafka = ::google::cloud::managedkafka_v1;
34+
auto client = managedkafka::ManagedKafkaClient(
35+
managedkafka::MakeManagedKafkaConnection());
3636

37-
for (auto r : client.List /*EDIT HERE*/ (location.FullName())) {
37+
for (auto r : client.ListClusters(location.FullName())) {
3838
if (!r) throw std::move(r).status();
3939
std::cout << r->DebugString() << "\n";
4040
}

google/cloud/managedkafka/quickstart/.bazelrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.
@@ -28,3 +28,6 @@ build:macos --host_cxxopt=-std=c++14
2828
# runs inside a docker image or if one builds a quickstart and then builds
2929
# the project separately.
3030
build --experimental_convenience_symlinks=ignore
31+
32+
#Our quickstarts do not yet support bzlmod
33+
build --noenable_bzlmod

google/cloud/managedkafka/quickstart/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.

google/cloud/managedkafka/quickstart/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
44
# use this file except in compliance with the License. You may obtain a copy of

google/cloud/managedkafka/quickstart/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.

google/cloud/managedkafka/quickstart/README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# HOWTO: using the Managed Service for Apache Kafka API C++ client in your project
22

3-
This directory contains small examples showing how to use the Managed Service
4-
for Apache Kafka API C++ client library in your own project. These instructions
5-
assume that you have some experience as a C++ developer and that you have a
6-
working C++ toolchain (compiler, linker, etc.) installed on your platform.
3+
This directory contains small examples showing how to use the Apache Kafka for
4+
BigQuery API C++ client library in your own project. These instructions assume
5+
that you have some experience as a C++ developer and that you have a working C++
6+
toolchain (compiler, linker, etc.) installed on your platform.
77

88
- Packaging maintainers or developers who prefer to install the library in a
99
fixed directory (such as `/usr/local` or `/opt`) should consult the
@@ -24,7 +24,8 @@ working C++ toolchain (compiler, linker, etc.) installed on your platform.
2424
## Before you begin
2525

2626
To run the quickstart examples you will need a working Google Cloud Platform
27-
(GCP) project.
27+
(GCP) project. The [quickstart][quickstart-link] covers the necessary steps in
28+
detail.
2829

2930
## Configuring authentication for the C++ Client Library
3031

@@ -134,3 +135,4 @@ set GRPC_DEFAULT_SSL_ROOTS_FILE_PATH=%cd%\roots.pem
134135
[grpc-roots-pem-bug]: https://github.com/grpc/grpc/issues/16571
135136
[homebrew-cmake-link]: https://formulae.brew.sh/formula/cmake
136137
[howto-setup-dev-workstation]: /doc/contributor/howto-guide-setup-development-workstation.md
138+
[quickstart-link]: https://cloud.google.com/managed-kafka/docs/quickstart

google/cloud/managedkafka/quickstart/WORKSPACE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2025 Google LLC
1+
# Copyright 2024 Google LLC
22
#
33
# Licensed under the Apache License, Version 2.0 (the "License");
44
# you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)