wait consistency wip

Author: scotthart

google/cloud/bigtable/admin/bigtable_table_admin_client.cc

@@ -822,13 +822,13 @@ BigtableTableAdminClient::AsyncCheckConsistency(
 }
 
 future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-     BigtableTableAdminClient::WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const& request,
-                     Options opts) {
+BigtableTableAdminClient::WaitForConsistency(
+    google::bigtable::admin::v2::CheckConsistencyRequest const& request,
+    Options opts) {
   internal::OptionsSpan span(internal::MergeOptions(std::move(opts), options_));
   return connection_->WaitForConsistency(request);
 }
 
-
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace bigtable_admin
 }  // namespace cloud

google/cloud/bigtable/admin/bigtable_table_admin_client.h

@@ -2581,9 +2581,10 @@ class BigtableTableAdminClient {
       google::bigtable::admin::v2::CheckConsistencyRequest const& request,
       Options opts = {});
 
-future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-     WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const& request,
-                     Options opts = {});
+  future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
+  WaitForConsistency(
+      google::bigtable::admin::v2::CheckConsistencyRequest const& request,
+      Options opts = {});
 
  private:
   std::shared_ptr<BigtableTableAdminConnection> connection_;

google/cloud/bigtable/admin/bigtable_table_admin_connection.cc

@@ -383,8 +383,9 @@ BigtableTableAdminConnection::AsyncCheckConsistency(
 }
 
 future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-     BigtableTableAdminConnection::WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const& request) {
-    return google::cloud::make_ready_future<
+BigtableTableAdminConnection::WaitForConsistency(
+    google::bigtable::admin::v2::CheckConsistencyRequest const&) {
+  return google::cloud::make_ready_future<
       StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>(
       Status(StatusCode::kUnimplemented, "not implemented"));
 }

google/cloud/bigtable/admin/bigtable_table_admin_connection.h

@@ -382,8 +382,10 @@ class BigtableTableAdminConnection {
   AsyncCheckConsistency(
       google::bigtable::admin::v2::CheckConsistencyRequest const& request);
 
-  virtual future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-     WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const& request);
+  virtual future<
+      StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
+  WaitForConsistency(
+      google::bigtable::admin::v2::CheckConsistencyRequest const& request);
 
  protected:
   friend StatusOr<CompletionQueue> bigtable_admin_internal::completion_queue(

google/cloud/bigtable/admin/internal/bigtable_table_admin_connection_impl.cc

@@ -1299,18 +1299,17 @@ BigtableTableAdminConnectionImpl::AsyncCheckConsistency(
 }
 
 future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-    BigtableTableAdminConnectionImpl::WaitForConsistency(
+BigtableTableAdminConnectionImpl::WaitForConsistency(
     google::bigtable::admin::v2::CheckConsistencyRequest const& request) {
-    auto current = google::cloud::internal::SaveCurrentOptions();
+  auto current = google::cloud::internal::SaveCurrentOptions();
   auto request_copy = request;
   auto const idempotent =
       idempotency_policy(*current)->CheckConsistency(request_copy);
   auto retry = retry_policy(*current);
   auto backoff = backoff_policy(*current);
-  auto attempt_predicate = [](
-                               StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse> const& r) {
-    return r.ok() && r->consistent();
-  };
+  auto attempt_predicate =
+      [](StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse> const&
+             r) { return r.ok() && r->consistent(); };
   return google::cloud::internal::AsyncRetryLoop(
       std::move(retry), std::move(backoff), idempotent, background_->cq(),
       [stub = stub_](

google/cloud/bigtable/admin/internal/bigtable_table_admin_connection_impl.h

@@ -235,7 +235,8 @@ class BigtableTableAdminConnectionImpl
       override;
 
   future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
-     WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const& request) override;
+  WaitForConsistency(google::bigtable::admin::v2::CheckConsistencyRequest const&
+                         request) override;
 
  private:
   std::unique_ptr<google::cloud::BackgroundThreads> background_;

google/cloud/bigtable/examples/table_admin_snippets.cc

@@ -643,8 +643,8 @@ void WaitForConsistencyCheck(
       throw std::move(consistency_token).status();
     }
     auto token = consistency_token->consistency_token();
-//    auto consistency_future =
-//        cbta::WaitForConsistency(connection, table_name, token);
+    //    auto consistency_future =
+    //        cbta::WaitForConsistency(connection, table_name, token);
 
     google::bigtable::admin::v2::CheckConsistencyRequest wait_request;
     wait_request.set_name(table_name);

google/cloud/bigtable/tests/table_admin_integration_test.cc

@@ -322,16 +322,18 @@ TEST_F(TableAdminIntegrationTest, WaitForConsistencyCheck) {
 
   // Wait until all the mutations before the `consistency_token` have propagated
   // everywhere.
-//  google::cloud::future<google::cloud::StatusOr<bigtable_admin::Consistency>>
-//      result = google::cloud::bigtable_admin::WaitForConsistency(
-//          table_admin_connection, table_created->name(),
-//          consistency_token->consistency_token());
+  //  google::cloud::future<google::cloud::StatusOr<bigtable_admin::Consistency>>
+  //      result = google::cloud::bigtable_admin::WaitForConsistency(
+  //          table_admin_connection, table_created->name(),
+  //          consistency_token->consistency_token());
 
   google::bigtable::admin::v2::CheckConsistencyRequest wait_request;
   wait_request.set_name(table_created->name());
   wait_request.set_consistency_token(consistency_token->consistency_token());
-  future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>> result = table_admin->WaitForConsistency(wait_request);
-  StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse> is_consistent = result.get();
+  future<StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>>
+      result = table_admin->WaitForConsistency(wait_request);
+  StatusOr<google::bigtable::admin::v2::CheckConsistencyResponse>
+      is_consistent = result.get();
   ASSERT_STATUS_OK(is_consistent);
   EXPECT_TRUE(is_consistent->consistent());