impl(v3): remove backward compatibility cmake proto libs (#15931)

Author: scotthart

ci/cloudbuild/builds/lib/quickstart.sh

@@ -31,10 +31,15 @@ source module ci/cloudbuild/builds/lib/cmake.sh
 source module ci/etc/quickstart-config.sh
 source module ci/lib/io.sh
 
+quickstart_program=""
+
 function cleanup() {
   local exit_status=$?
   io::log_h2 "cleanup on EXIT with exit_status=${exit_status}"
-  io::run find . -name '*core*'
+  if ((exit_status != 0)); then
+    io::run find . -name 'core'
+    gdb --exec="${quickstart_program}" --core=./core --eval-command="bt full"
+  fi
 }
 
 trap 'cleanup' INT TERM EXIT
@@ -136,6 +141,7 @@ function quickstart::run_one_quickstart() {
 
   io::log "[ CMake ]"
   local cmake_bin_dir="${PROJECT_ROOT}/cmake-out/quickstart/cmake-${bin_dir_suffix}"
+  quickstart_program="${cmake_bin_dir}/quickstart"
   if command -v /usr/bin/valgrind >/dev/null 2>&1; then
     io::run valgrind --leak-check=full "${cmake_bin_dir}/quickstart" "${run_args[@]}"
   else

ci/verify_current_targets/CMakeLists.txt

@@ -79,23 +79,13 @@ endforeach ()
 
 # Verify backwards compatible proto libraries are installed. See #8022 for more
 # details.
-foreach (library "dialogflow_es" "iam" "monitoring" "speech" "texttospeech"
-                 "trace")
+foreach (library "iam")
     find_package(google_cloud_cpp_${library})
 endforeach ()
 
 set(backwards_compat_proto_libraries
     # cmake-format: sortable
-    "cloud_dialogflow_v2_protos"
-    "cloud_speech_protos"
-    "cloud_texttospeech_protos"
-    "devtools_cloudtrace_v2_trace_protos"
-    "devtools_cloudtrace_v2_tracing_protos"
-    "iam_v1_iam_policy_protos"
-    "iam_v1_options_protos"
-    "iam_v1_policy_protos"
-    "logging_type_protos"
-    "logging_type_type_protos")
+    "iam_v1_iam_policy_protos" "iam_v1_options_protos" "iam_v1_policy_protos")
 
 foreach (library ${backwards_compat_proto_libraries})
     add_test_case(test_cmake_${library} google-cloud-cpp::common

cmake/GoogleCloudCppLibrary.cmake

@@ -222,17 +222,6 @@ function (google_cloud_cpp_add_gapic_library library display_name)
     list(TRANSFORM shared_proto_dep_targets PREPEND "google_cloud_cpp_")
     list(TRANSFORM shared_proto_dep_targets APPEND "_protos")
 
-    # We used to offer the proto library by another name. Maintain backwards
-    # compatibility by providing an interface library with that name. Also make
-    # sure we install it as part of google_cloud_cpp_${library}-targets.
-    unset(backwards_compat_proto_targets)
-    foreach (old_protos IN LISTS _opt_BACKWARDS_COMPAT_PROTO_TARGETS)
-        google_cloud_cpp_backwards_compat_protos_library("${old_protos}"
-                                                         "${library}_protos")
-        list(APPEND backwards_compat_proto_targets
-             "google_cloud_cpp_${old_protos}")
-    endforeach ()
-
     file(
         GLOB source_files
         RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}"

doc/v3-migration-guide.md

@@ -42,6 +42,25 @@ module which can be added to your `MODULE.bazel` file as a dependency.
 
 ### CMake
 
+<details>
+<summary>Removed backward compatible proto interface libraries.</summary>
+
+If your application links directly to one of these decommissioned proto
+libraries, the CMakeLists.txt should be updated with the preferred proto library
+name.
+
+| Library                    | Decommissioned Proto Library          | Preferred Proto Library                |
+| -------------------------- | ------------------------------------- | -------------------------------------- |
+| google/cloud/dialogflow_es | cloud_dialogflow_v2_protos            | google-cloud-cpp::dialogflow_es_protos |
+| google/cloud/logging       | logging_type_protos                   | google-cloud-cpp::logging_protos       |
+| google/cloud/logging       | logging_type_type_protos              | google-cloud-cpp::logging_protos       |
+| google/cloud/speech        | cloud_speech_protos                   | google-cloud-cpp::speech_protos        |
+| google/cloud/texttospeech  | cloud_texttospeech_protos             | google-cloud-cpp::texttospeech_protos  |
+| google/cloud/trace         | devtools_cloudtrace_v2_tracing_protos | google-cloud-cpp::trace_protos         |
+| google/cloud/trace         | devtools_cloudtrace_v2_trace_protos   | google-cloud-cpp::trace_protos         |
+
+</details>
+
 ### Common
 
 <details>