resolved review comments

v-pratap · v-pratap · commit cf86a3e68f29 · 2026-04-08T08:00:08.000Z
diff --git a/google/cloud/storage/async/object_descriptor_connection.h b/google/cloud/storage/async/object_descriptor_connection.h
@@ -68,7 +68,7 @@ class ObjectDescriptorConnection {
    * A descriptor is open if it has not been cancelled and has not hit a
    * permanent failure.
    */
-  virtual bool IsOpen() const { return true; }
+  virtual bool IsOpen() const = 0;
 };
 
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
diff --git a/google/cloud/storage/internal/async/object_descriptor_impl.cc b/google/cloud/storage/internal/async/object_descriptor_impl.cc
@@ -66,7 +66,7 @@ void ObjectDescriptorImpl::Start(
 
 bool ObjectDescriptorImpl::IsOpen() const {
   {
-    std::unique_lock<std::mutex> lk(mu_);
+    std::scoped_lock<std::mutex> lk(mu_);
     if (cancelled_) return false;
     if (stream_manager_->Empty()) return false;
   }

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ void ObjectDescriptorImpl::Start(`
`66`	`66`
`67`	`67`	`bool ObjectDescriptorImpl::IsOpen() const {`
`68`	`68`	`{`
`69`		`- std::unique_lock<std::mutex> lk(mu_);`
	`69`	`+ std::scoped_lock<std::mutex> lk(mu_);`
`70`	`70`	`if (cancelled_) return false;`
`71`	`71`	`if (stream_manager_->Empty()) return false;`
`72`	`72`	`}`