formatting

scotthart · scotthart · commit db3f1cc88738 · 2025-06-06T19:24:48.000-04:00
diff --git a/google/cloud/bigtable/internal/defaults.cc b/google/cloud/bigtable/internal/defaults.cc
@@ -73,13 +73,11 @@ Options DefaultConnectionRefreshOptions(Options opts) {
     opts.set<MinConnectionRefreshOption>(kDefaultMinRefreshPeriod);
     opts.set<MaxConnectionRefreshOption>(kDefaultMaxRefreshPeriod);
   } else if (has_min && !has_max) {
-    opts.set<MaxConnectionRefreshOption>(
-        (std::max)(opts.get<MinConnectionRefreshOption>(),
-                   kDefaultMaxRefreshPeriod));
+    opts.set<MaxConnectionRefreshOption>((std::max)(
+        opts.get<MinConnectionRefreshOption>(), kDefaultMaxRefreshPeriod));
   } else if (!has_min && has_max) {
-    opts.set<MinConnectionRefreshOption>(
-        (std::min)(opts.get<MaxConnectionRefreshOption>(),
-                   kDefaultMinRefreshPeriod));
+    opts.set<MinConnectionRefreshOption>((std::min)(
+        opts.get<MaxConnectionRefreshOption>(), kDefaultMinRefreshPeriod));
   } else {
     // If the range is invalid, use the greater value as both the min and max
     auto const p = opts.get<MinConnectionRefreshOption>();
diff --git a/google/cloud/compute/doc/environment-variables.dox b/google/cloud/compute/doc/environment-variables.dox
@@ -326,6 +326,10 @@ environment variables are convenient when troubleshooting problems.
   `EndpointOption` (which defaults to "compute.googleapis.com")
   used by `MakeReservationBlocksConnection()`.
 
+- `GOOGLE_CLOUD_CPP_RESERVATION_SUB_BLOCKS_ENDPOINT=...` overrides the
+  `EndpointOption` (which defaults to "compute.googleapis.com")
+  used by `MakeReservationSubBlocksConnection()`.
+
 - `GOOGLE_CLOUD_CPP_RESOURCE_POLICIES_ENDPOINT=...` overrides the
   `EndpointOption` (which defaults to "compute.googleapis.com")
   used by `MakeResourcePoliciesConnection()`.
diff --git a/google/cloud/compute/doc/main.dox b/google/cloud/compute/doc/main.dox
@@ -109,6 +109,7 @@ application.
 - [\c compute_region_zones_v1::RegionZonesClient](@ref google::cloud::compute_region_zones_v1::RegionZonesClient)
 - [\c compute_regions_v1::RegionsClient](@ref google::cloud::compute_regions_v1::RegionsClient)
 - [\c compute_reservation_blocks_v1::ReservationBlocksClient](@ref google::cloud::compute_reservation_blocks_v1::ReservationBlocksClient)
+- [\c compute_reservation_sub_blocks_v1::ReservationSubBlocksClient](@ref google::cloud::compute_reservation_sub_blocks_v1::ReservationSubBlocksClient)
 - [\c compute_reservations_v1::ReservationsClient](@ref google::cloud::compute_reservations_v1::ReservationsClient)
 - [\c compute_resource_policies_v1::ResourcePoliciesClient](@ref google::cloud::compute_resource_policies_v1::ResourcePoliciesClient)
 - [\c compute_routers_v1::RoutersClient](@ref google::cloud::compute_routers_v1::RoutersClient)
diff --git a/google/cloud/compute/doc/override-authentication.dox b/google/cloud/compute/doc/override-authentication.dox
@@ -91,6 +91,7 @@ Follow these links to find examples for other \c *Client classes:
 - [\c compute_region_zones_v1::RegionZonesClient](@ref compute_region_zones_v1::RegionZonesClient-service-account-snippet)
 - [\c compute_regions_v1::RegionsClient](@ref compute_regions_v1::RegionsClient-service-account-snippet)
 - [\c compute_reservation_blocks_v1::ReservationBlocksClient](@ref compute_reservation_blocks_v1::ReservationBlocksClient-service-account-snippet)
+- [\c compute_reservation_sub_blocks_v1::ReservationSubBlocksClient](@ref compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-service-account-snippet)
 - [\c compute_reservations_v1::ReservationsClient](@ref compute_reservations_v1::ReservationsClient-service-account-snippet)
 - [\c compute_resource_policies_v1::ResourcePoliciesClient](@ref compute_resource_policies_v1::ResourcePoliciesClient-service-account-snippet)
 - [\c compute_routers_v1::RoutersClient](@ref compute_routers_v1::RoutersClient-service-account-snippet)
@@ -602,6 +603,12 @@ guide for more details.
 
 */
 
+/*! @page compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-service-account-snippet Override compute_reservation_sub_blocks_v1::ReservationSubBlocksClient Authentication Defaults
+
+@snippet google/cloud/compute/reservation_sub_blocks/v1/samples/reservation_sub_blocks_client_samples.cc with-service-account
+
+*/
+
 /*! @page compute_reservations_v1::ReservationsClient-service-account-snippet Override compute_reservations_v1::ReservationsClient Authentication Defaults
 
 @snippet google/cloud/compute/reservations/v1/samples/reservations_client_samples.cc with-service-account
diff --git a/google/cloud/compute/doc/override-endpoint.dox b/google/cloud/compute/doc/override-endpoint.dox
@@ -91,6 +91,7 @@ Follow these links to find examples for other \c *Client classes:
 - [\c compute_region_zones_v1::RegionZonesClient](@ref compute_region_zones_v1::RegionZonesClient-endpoint-snippet)
 - [\c compute_regions_v1::RegionsClient](@ref compute_regions_v1::RegionsClient-endpoint-snippet)
 - [\c compute_reservation_blocks_v1::ReservationBlocksClient](@ref compute_reservation_blocks_v1::ReservationBlocksClient-endpoint-snippet)
+- [\c compute_reservation_sub_blocks_v1::ReservationSubBlocksClient](@ref compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-endpoint-snippet)
 - [\c compute_reservations_v1::ReservationsClient](@ref compute_reservations_v1::ReservationsClient-endpoint-snippet)
 - [\c compute_resource_policies_v1::ResourcePoliciesClient](@ref compute_resource_policies_v1::ResourcePoliciesClient-endpoint-snippet)
 - [\c compute_routers_v1::RoutersClient](@ref compute_routers_v1::RoutersClient-endpoint-snippet)
@@ -592,6 +593,12 @@ Follow these links to find examples for other \c *Client classes:
 
 */
 
+/*! @page compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-endpoint-snippet Override compute_reservation_sub_blocks_v1::ReservationSubBlocksClient Endpoint Configuration
+
+@snippet google/cloud/compute/reservation_sub_blocks/v1/samples/reservation_sub_blocks_client_samples.cc set-client-endpoint
+
+*/
+
 /*! @page compute_reservations_v1::ReservationsClient-endpoint-snippet Override compute_reservations_v1::ReservationsClient Endpoint Configuration
 
 @snippet google/cloud/compute/reservations/v1/samples/reservations_client_samples.cc set-client-endpoint
diff --git a/google/cloud/compute/doc/override-retry-policies.dox b/google/cloud/compute/doc/override-retry-policies.dox
@@ -157,6 +157,7 @@ Follow these links to find examples for other \c *Client classes:
 - [\c compute_region_zones_v1::RegionZonesClient](@ref compute_region_zones_v1::RegionZonesClient-retry-snippet)
 - [\c compute_regions_v1::RegionsClient](@ref compute_regions_v1::RegionsClient-retry-snippet)
 - [\c compute_reservation_blocks_v1::ReservationBlocksClient](@ref compute_reservation_blocks_v1::ReservationBlocksClient-retry-snippet)
+- [\c compute_reservation_sub_blocks_v1::ReservationSubBlocksClient](@ref compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-retry-snippet)
 - [\c compute_reservations_v1::ReservationsClient](@ref compute_reservations_v1::ReservationsClient-retry-snippet)
 - [\c compute_resource_policies_v1::ResourcePoliciesClient](@ref compute_resource_policies_v1::ResourcePoliciesClient-retry-snippet)
 - [\c compute_routers_v1::RoutersClient](@ref compute_routers_v1::RoutersClient-retry-snippet)
@@ -1134,6 +1135,18 @@ Assuming you have created a custom idempotency policy. Such as:
 
 */
 
+/*! @page compute_reservation_sub_blocks_v1::ReservationSubBlocksClient-retry-snippet Override compute_reservation_sub_blocks_v1::ReservationSubBlocksClient Retry Policies
+
+This shows how to override the retry policies for compute_reservation_sub_blocks_v1::ReservationSubBlocksClient:
+
+@snippet google/cloud/compute/reservation_sub_blocks/v1/samples/reservation_sub_blocks_client_samples.cc set-retry-policy
+
+Assuming you have created a custom idempotency policy. Such as:
+
+@snippet google/cloud/compute/reservation_sub_blocks/v1/samples/reservation_sub_blocks_client_samples.cc custom-idempotency-policy
+
+*/
+
 /*! @page compute_reservations_v1::ReservationsClient-retry-snippet Override compute_reservations_v1::ReservationsClient Retry Policies
 
 This shows how to override the retry policies for compute_reservations_v1::ReservationsClient:
diff --git a/google/cloud/compute/service_dirs.cmake b/google/cloud/compute/service_dirs.cmake
@@ -16,7 +16,6 @@
 
 set(service_dirs
     # cmake-format: sort
-    "reservation_sub_blocks/v1/"
     "accelerator_types/v1/"
     "addresses/v1/"
     "autoscalers/v1/"
@@ -92,6 +91,7 @@ set(service_dirs
     "region_zones/v1/"
     "regions/v1/"
     "reservation_blocks/v1/"
+    "reservation_sub_blocks/v1/"
     "reservations/v1/"
     "resource_policies/v1/"
     "routers/v1/"
diff --git a/google/cloud/future_generic.h b/google/cloud/future_generic.h
@@ -109,11 +109,12 @@ class future final : private internal::future_base<T> {
    * Side effects: `valid() == false` if the operation is successful.
    */
   template <typename F>
-  auto then(F&& func) -> future<
-      /// @cond implementation_details
-      internal::UnwrappedType<internal::invoke_result_t<F, future<T>>>
-      /// @endcond
-      >;
+  auto then(F&& func)
+      -> future<
+          /// @cond implementation_details
+          internal::UnwrappedType<internal::invoke_result_t<F, future<T>>>
+          /// @endcond
+          >;
 
   explicit future(std::shared_ptr<shared_state_type> state)
       : internal::future_base<T>(std::move(state)) {}
diff --git a/google/cloud/future_generic_then_test.cc b/google/cloud/future_generic_then_test.cc
@@ -417,8 +417,8 @@ TEST(FutureTestInt, conform_2_3_5) {
 
 // Use SFINAE to test if future<int>::then() accepts a T parameter.
 template <typename T>
-auto test_then(int)
-    -> decltype(std::declval<future<int>>().then(T()), std::true_type{}) {
+auto test_then(int) -> decltype(std::declval<future<int>>().then(T()),
+                                std::true_type{}) {
   return std::true_type{};
 }
 
diff --git a/google/cloud/future_void.h b/google/cloud/future_void.h
@@ -103,11 +103,12 @@ class future<void> final : private internal::future_base<internal::FutureVoid> {
    * Side effects: `valid() == false` if the operation is successful.
    */
   template <typename F>
-  auto then(F&& func) -> future<
-      /// @cond implementation_details
-      internal::UnwrappedType<internal::invoke_result_t<F, future<void>>>
-      /// @endcond
-      >;
+  auto then(F&& func)
+      -> future<
+          /// @cond implementation_details
+          internal::UnwrappedType<internal::invoke_result_t<F, future<void>>>
+          /// @endcond
+          >;
 
   explicit future(std::shared_ptr<shared_state_type> state)
       : future_base<internal::FutureVoid>(std::move(state)) {}
diff --git a/google/cloud/future_void_then_test.cc b/google/cloud/future_void_then_test.cc
@@ -405,8 +405,8 @@ TEST(FutureTestVoid, conform_2_3_5) {
 
 // Use SFINAE to test if future<void>::then() accepts a T parameter.
 template <typename T>
-auto test_then(int)
-    -> decltype(std::declval<future<void>>().then(T()), std::true_type{}) {
+auto test_then(int) -> decltype(std::declval<future<void>>().then(T()),
+                                std::true_type{}) {
   return std::true_type{};
 }
 
diff --git a/google/cloud/internal/background_threads_impl_test.cc b/google/cloud/internal/background_threads_impl_test.cc
@@ -36,9 +36,7 @@ TEST(CustomerSuppliedBackgroundThreads, LifecycleNoShutdown) {
     p.set_value();
   });
 
-  {
-    CustomerSuppliedBackgroundThreads actual(cq);
-  }
+  { CustomerSuppliedBackgroundThreads actual(cq); }
 
   using ms = std::chrono::milliseconds;
 
diff --git a/google/cloud/internal/future_then_impl.h b/google/cloud/internal/future_then_impl.h
@@ -225,8 +225,9 @@ future<T>::future(future<U>&& rhs)
 
 template <typename T>
 template <typename F>
-auto future<T>::then(F&& functor) -> future<
-    internal::UnwrappedType<internal::invoke_result_t<F, future<T>>>> {
+auto future<T>::then(F&& functor)
+    -> future<
+        internal::UnwrappedType<internal::invoke_result_t<F, future<T>>>> {
   return internal::FutureThenImpl::then_impl(*this, std::forward<F>(functor));
 }
 
@@ -239,8 +240,9 @@ future<void>::future(future<T>&& rhs)
           internal::FutureThenImpl::ctor_convert<void>(std::move(rhs))) {}
 
 template <typename F>
-auto future<void>::then(F&& functor) -> future<
-    internal::UnwrappedType<internal::invoke_result_t<F, future<void>>>> {
+auto future<void>::then(F&& functor)
+    -> future<
+        internal::UnwrappedType<internal::invoke_result_t<F, future<void>>>> {
   return internal::FutureThenImpl::then_impl(*this, std::forward<F>(functor));
 }
 
diff --git a/google/cloud/internal/invoke_result.h b/google/cloud/internal/invoke_result.h
@@ -94,7 +94,7 @@ struct invoke_impl<MT B::*> {
    */
   template <class T, class... Args,
             std::enable_if_t<std::is_function<MT>::value, int> = 0>
-  static auto call(MT B::* f, T&& t, Args&&... a)
+  static auto call(MT B::*f, T&& t, Args&&... a)
       -> decltype((std::forward<T>(t).*f)(std::forward<Args>(a)...));
 };
 
diff --git a/google/cloud/opentelemetry/internal/time_series.cc b/google/cloud/opentelemetry/internal/time_series.cc
@@ -123,9 +123,9 @@ google::monitoring::v3::TimeInterval ToNonGaugeTimeInterval(
   // the start value.
   //
   // https://cloud.google.com/monitoring/api/ref_v3/rpc/google.monitoring.v3#timeinterval
-  auto end_ts_nanos = (std::max)(metric_data.end_ts.time_since_epoch(),
-                                 metric_data.start_ts.time_since_epoch() +
-                                     std::chrono::milliseconds(1));
+  auto end_ts_nanos = (std::max)(
+      metric_data.end_ts.time_since_epoch(),
+      metric_data.start_ts.time_since_epoch() + std::chrono::milliseconds(1));
 
   google::monitoring::v3::TimeInterval proto;
   *proto.mutable_start_time() = ToProtoTimestamp(metric_data.start_ts);
diff --git a/google/cloud/pubsub/ack_handler_test.cc b/google/cloud/pubsub/ack_handler_test.cc
@@ -27,9 +27,7 @@ using ::testing::Return;
 TEST(AckHandlerTest, AutoNack) {
   auto mock = std::make_unique<pubsub_mocks::MockAckHandler>();
   EXPECT_CALL(*mock, nack()).Times(1);
-  {
-    AckHandler handler(std::move(mock));
-  }
+  { AckHandler handler(std::move(mock)); }
 }
 
 TEST(AckHandlerTest, AutoNackMove) {
diff --git a/google/cloud/pubsub/exactly_once_ack_handler_test.cc b/google/cloud/pubsub/exactly_once_ack_handler_test.cc
@@ -32,9 +32,7 @@ TEST(AckHandlerTest, AutoNack) {
   auto mock = std::make_unique<MockExactlyOnceAckHandler>();
   EXPECT_CALL(*mock, nack())
       .WillOnce(Return(ByMove(make_ready_future(Status{}))));
-  {
-    ExactlyOnceAckHandler handler(std::move(mock));
-  }
+  { ExactlyOnceAckHandler handler(std::move(mock)); }
 }
 
 TEST(AckHandlerTest, AutoNackMove) {
diff --git a/google/cloud/pubsub/pull_ack_handler_test.cc b/google/cloud/pubsub/pull_ack_handler_test.cc
@@ -32,9 +32,7 @@ TEST(AckHandlerTest, AutoNack) {
   auto mock = std::make_unique<MockPullAckHandler>();
   EXPECT_CALL(*mock, nack())
       .WillOnce(Return(ByMove(make_ready_future(Status{}))));
-  {
-    PullAckHandler handler(std::move(mock));
-  }
+  { PullAckHandler handler(std::move(mock)); }
 }
 
 TEST(AckHandlerTest, AutoNackMove) {
diff --git a/google/cloud/storage/async/rewriter.cc b/google/cloud/storage/async/rewriter.cc
@@ -51,7 +51,7 @@ future<StatusOr<IterateResponse>> AsyncRewriter::Iterate(AsyncToken token) {
   if (token != t) return TokenError<IterateResponse>(GCP_ERROR_INFO());
 
   return impl_->Iterate().then([t = std::move(t), impl = impl_](auto f) mutable
-                                   -> StatusOr<IterateResponse> {
+                               -> StatusOr<IterateResponse> {
     auto r = f.get();
     if (!r) return std::move(r).status();
     auto const done = r->has_resource();
diff --git a/google/cloud/storage/benchmarks/async_throughput_benchmark.cc b/google/cloud/storage/benchmarks/async_throughput_benchmark.cc
@@ -587,8 +587,8 @@ g::future<IterationResult> Upload(Configuration const& cfg,
 }
 
 template <typename F, typename... Args>
-auto Launch(F&& function, Args&&... a)
-    -> g::future<std::invoke_result_t<F, Args...>> {
+auto Launch(F&& function,
+            Args&&... a) -> g::future<std::invoke_result_t<F, Args...>> {
   using R = std::invoke_result_t<F, Args...>;
   g::promise<R> p;
   auto f = p.get_future();
diff --git a/google/cloud/storage/client.cc b/google/cloud/storage/client.cc
@@ -139,9 +139,9 @@ StatusOr<ObjectMetadata> Client::UploadFileSimple(
     return google::cloud::internal::InvalidArgumentError(std::move(os).str(),
                                                          GCP_ERROR_INFO());
   }
-  auto upload_size = (std::min)(request.GetOption<UploadLimit>().value_or(
-                                    file_size - upload_offset),
-                                file_size - upload_offset);
+  auto upload_size = (std::min)(
+      request.GetOption<UploadLimit>().value_or(file_size - upload_offset),
+      file_size - upload_offset);
 
   std::ifstream is(file_name, std::ios::binary);
   if (!is.is_open()) {
@@ -205,9 +205,9 @@ integrity checks using the DisableMD5Hash() and DisableCrc32cChecksum() options.
                                                            GCP_ERROR_INFO());
     }
 
-    auto upload_size = (std::min)(request.GetOption<UploadLimit>().value_or(
-                                      file_size - upload_offset),
-                                  file_size - upload_offset);
+    auto upload_size = (std::min)(
+        request.GetOption<UploadLimit>().value_or(file_size - upload_offset),
+        file_size - upload_offset);
     request.set_option(UploadContentLength(upload_size));
   }
   std::ifstream source(file_name, std::ios::binary);
diff --git a/google/cloud/storage/grpc_plugin.h b/google/cloud/storage/grpc_plugin.h
@@ -49,8 +49,8 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
  *     gRPC-based clients. If you need to pick one dynamically a simple
  *     `if()` statement or ternary expression can do the job.
  */
-struct [[deprecated("use storage::Client() or storage::MakeGrpcClient()")]]
-GrpcPluginOption {
+struct [[deprecated(
+    "use storage::Client() or storage::MakeGrpcClient()")]] GrpcPluginOption {
   using Type = std::string;
 };
 
diff --git a/google/cloud/storage/internal/async/connection_impl.cc b/google/cloud/storage/internal/async/connection_impl.cc
@@ -378,8 +378,8 @@ AsyncConnectionImpl::AppendableObjectUploadImpl(AppendableUploadParams p) {
   return pending.then(
       [current, request = std::move(p.request), persisted_size,
        hash = std::move(hash_function), fa = std::move(factory)](auto f) mutable
-          -> StatusOr<
-              std::unique_ptr<storage_experimental::AsyncWriterConnection>> {
+      -> StatusOr<
+          std::unique_ptr<storage_experimental::AsyncWriterConnection>> {
         auto rpc = f.get();
         if (!rpc) return std::move(rpc).status();
         persisted_size = rpc->first_response.resource().size();
@@ -428,8 +428,8 @@ AsyncConnectionImpl::StartBufferedUpload(UploadParams p) {
   return StartUnbufferedUpload(std::move(p))
       .then([current = std::move(current),
              async_write_object = std::move(async_write_object)](auto f) mutable
-                -> StatusOr<std::unique_ptr<
-                    storage_experimental::AsyncWriterConnection>> {
+            -> StatusOr<
+                std::unique_ptr<storage_experimental::AsyncWriterConnection>> {
         auto w = f.get();
         if (!w) return std::move(w).status();
         auto factory = [upload_id = (*w)->UploadId(),
@@ -466,8 +466,8 @@ AsyncConnectionImpl::ResumeBufferedUpload(ResumeUploadParams p) {
   return f.then(
       [current = std::move(current),
        make_unbuffered = std::move(make_unbuffered)](auto f) mutable
-          -> StatusOr<
-              std::unique_ptr<storage_experimental::AsyncWriterConnection>> {
+      -> StatusOr<
+          std::unique_ptr<storage_experimental::AsyncWriterConnection>> {
         auto w = f.get();
         if (!w) return std::move(w).status();
         return MakeWriterConnectionBuffered(std::move(make_unbuffered),
diff --git a/google/cloud/storage/parallel_uploads_test.cc b/google/cloud/storage/parallel_uploads_test.cc
diff --git a/google/cloud/testing_util/timer.cc b/google/cloud/testing_util/timer.cc

Original file line number	Diff line number	Diff line change
`@@ -417,8 +417,8 @@ TEST(FutureTestInt, conform_2_3_5) {`
`417`	`417`
`418`	`418`	`// Use SFINAE to test if future<int>::then() accepts a T parameter.`
`419`	`419`	`template <typename T>`
`420`		`-auto test_then(int)`
`421`		`- -> decltype(std::declval<future<int>>().then(T()), std::true_type{}) {`
	`420`	`+auto test_then(int) -> decltype(std::declval<future<int>>().then(T()),`
	`421`	`+ std::true_type{}) {`
`422`	`422`	`return std::true_type{};`
`423`	`423`	`}`
`424`	`424`