impl(v3): bazel non-public visibility for testing libs (#15929)

Author: scotthart

ci/cloudbuild/builds/bazel-targets.sh

@@ -21,7 +21,6 @@ source module ci/cloudbuild/builds/lib/bazel.sh
 source module ci/cloudbuild/builds/lib/cloudcxxrc.sh
 
 mapfile -t args < <(bazel::common_args)
-for repo_root in "ci/verify_current_targets" "ci/verify_deprecated_targets"; do
-  io::log_h2 "Verifying Bazel targets in repo root: ${repo_root}"
-  env -C "${repo_root}" bazel test "${args[@]}" ...
-done
+repo_root="ci/verify_current_targets"
+io::log_h2 "Verifying Bazel targets in repo root: ${repo_root}"
+env -C "${repo_root}" bazel test "${args[@]}" ...

ci/verify_deprecated_targets/BUILD.bazel

@@ -16,19 +16,12 @@ package(default_visibility = ["//visibility:private"])
 
 licenses(["notice"])  # Apache 2.0
 
-# TODO(#5726) - DO NOT CHANGE THESE TARGET NAMES These package names are
-# expected to remain usable until we have retired them. They are *deprecated*
-# (that is, we no longer recommend their use), but *NOT* retired (that is, they
-# remain available). This is a test for backwards compatibility. If you need to
-# change the test, there is good chance you are breaking something.
+# These package names are expected to remain usable until we have retired them.
+# They are *deprecated* (that is, we no longer recommend their use), but *NOT*
+# decommissioned (that is, they remain available). This is a test for backwards
+# compatibility. If you need to change the test, there is good chance you are
+# breaking something.
 DEPRECATED_TARGETS = [
-    "google/cloud/pubsub:pubsub_client_testing",
-    "google/cloud/spanner:spanner_client_testing",
-    "google/cloud/testing_util:google_cloud_cpp_testing",
-    "google/cloud/testing_util:google_cloud_cpp_testing_grpc",
-    "google/cloud/testing_util:google_cloud_cpp_testing_rest",
-    "google/cloud:google_cloud_cpp_common",
-    "google/cloud:google_cloud_cpp_grpc_utils",
 ]
 
 [cc_test(

google/cloud/BUILD.bazel

@@ -91,13 +91,11 @@ cc_library(
 
 cc_library(
     name = "google_cloud_cpp_common",
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. Use
-    //:common instead. More info:
-    https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":google_cloud_cpp_common_private"],
 )
 
@@ -162,13 +160,11 @@ cc_library(
 
 cc_library(
     name = "google_cloud_cpp_grpc_utils",
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. Use
-    //:grpc_utils instead. More info:
-    https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":google_cloud_cpp_grpc_utils_private"],
 )
 

google/cloud/bigtable/BUILD.bazel

@@ -100,7 +100,10 @@ cc_library(
     testonly = True,
     srcs = bigtable_client_testing_srcs,
     hdrs = bigtable_client_testing_hdrs,
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [
         ":google_cloud_cpp_bigtable",
         ":google_cloud_cpp_bigtable_mocks",

google/cloud/pubsub/BUILD.bazel

@@ -60,16 +60,14 @@ cc_library(
     ],
 )
 
-# TODO(#3701): Delete this target after 2023-04-01.
 cc_library(
     name = "pubsub_client_testing",
     testonly = True,
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. More
-    info: https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":pubsub_client_testing_private"],
 )
 

google/cloud/spanner/BUILD.bazel

@@ -110,16 +110,14 @@ cc_library(
     ],
 )
 
-# TODO(#3701): Delete this target after 2023-04-01.
 cc_library(
     name = "spanner_client_testing",
     testonly = True,
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. More
-    info: https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":spanner_client_testing_private"],
 )
 

google/cloud/storage/BUILD.bazel

@@ -185,7 +185,10 @@ cc_library(
     testonly = True,
     srcs = storage_client_testing_srcs,
     hdrs = storage_client_testing_hdrs,
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [
         ":google_cloud_cpp_storage",
         ":google_cloud_cpp_storage_grpc",

google/cloud/testing_util/BUILD.bazel

@@ -52,12 +52,11 @@ cc_library(
 cc_library(
     name = "google_cloud_cpp_testing",
     testonly = True,
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. More
-    info: https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":google_cloud_cpp_testing_private"],
 )
 
@@ -91,12 +90,11 @@ cc_library(
 cc_library(
     name = "google_cloud_cpp_testing_grpc",
     testonly = True,
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. More
-    info: https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":google_cloud_cpp_testing_grpc_private"],
 )
 
@@ -125,11 +123,10 @@ cc_library(
 cc_library(
     name = "google_cloud_cpp_testing_rest",
     testonly = True,
-    deprecation = """
-    This target is deprecated and will be removed on or after 2023-04-01. More
-    info: https://github.com/googleapis/google-cloud-cpp/issues/3701
-    """,
     tags = ["manual"],
-    visibility = ["//visibility:public"],
+    visibility = [
+        ":__subpackages__",
+        "//:__pkg__",
+    ],
     deps = [":google_cloud_cpp_testing_rest_private"],
 )