Skip to content

Commit ea26fad

Browse files
committed
more refactoring
1 parent 5b48aef commit ea26fad

1 file changed

Lines changed: 1 addition & 9 deletions

File tree

google/cloud/storage/internal/tracing_connection.cc

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void TracingConnection::ResetCacheForTesting() { cache().Clear(); }
6969
Options TracingConnection::options() const { return impl_->options(); }
7070

7171
void TracingConnection::CleanupCompletedTasks() {
72-
std::lock_guard<std::mutex> lock(mu_);
72+
std::unique_lock<std::mutex> lk(mu_);
7373
bg_tasks_.erase(std::remove_if(bg_tasks_.begin(), bg_tasks_.end(),
7474
[](std::future<void> const& f) {
7575
return f.wait_for(std::chrono::seconds(0)) ==
@@ -92,14 +92,6 @@ void TracingConnection::MaybeTriggerBackgroundFetch(
9292
google::cloud::internal::OptionsSpan span(current_options);
9393
storage::internal::GetBucketMetadataRequest request(bucket_name);
9494
auto result = impl_->GetBucketMetadata(request);
95-
std::cout << "BG Thread: GetBucketMetadata returned ok: " << result.ok()
96-
<< "\n";
97-
if (!result.ok()) {
98-
std::cout << "BG Thread: GetBucketMetadata status: "
99-
<< result.status().message()
100-
<< " code: " << static_cast<int>(result.status().code())
101-
<< "\n";
102-
}
10395

10496
BucketCacheEntry entry;
10597
if (result.ok()) {

0 commit comments

Comments
 (0)