Fix remaining styling issues and long lines

Author: v-pratap

google/cloud/storage/hashing_options.h

@@ -62,7 +62,6 @@ inline std::string ComputeMD5Hash(char const* payload) {
 }
 
 /**
-
  * Provide a pre-computed CRC32C checksum value.
  *
  * The application may be able to obtain a CRC32C checksum in some out-of-band
@@ -97,7 +96,6 @@ inline std::string ComputeCrc32cChecksum(char const* payload) {
                                                   : absl::string_view{payload});
 }
 
-
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace storage
 }  // namespace cloud

google/cloud/storage/internal/checksum_helpers.h

@@ -39,7 +39,6 @@ inline HashDisabled GetDownloadChecksumSettings(Options const& options) {
     disable_md5 = (algo != ChecksumAlgorithm::kMD5);
     disable_crc32c = (algo != ChecksumAlgorithm::kCrc32c);
   }
-
   return {disable_md5, disable_crc32c};
 }
 
@@ -51,7 +50,6 @@ inline HashDisabled GetUploadChecksumSettings(Options const& options) {
     disable_md5 = (algo != ChecksumAlgorithm::kMD5);
     disable_crc32c = (algo != ChecksumAlgorithm::kCrc32c);
   }
-
   return {disable_md5, disable_crc32c};
 }
 

google/cloud/storage/internal/hash_function_impl_test.cc

@@ -437,9 +437,14 @@ TEST(HashFunctionImplTest, CreateHashFunctionInsertObjectMedia) {
   auto const upload_cases = testing::UploadHashCases();
 
   for (auto const& test : upload_cases) {
-    bool disable_crc32c = (test.validation_algo == ChecksumAlgorithm::kNone || test.validation_algo == ChecksumAlgorithm::kMD5);
-    bool disable_md5 = (test.validation_algo == ChecksumAlgorithm::kNone || test.validation_algo == ChecksumAlgorithm::kCrc32c);
-    auto function = CreateHashFunction(test.crc32_value, disable_crc32c, test.md5_value, disable_md5);
+    bool disable_crc32c =
+        (test.validation_algo == ChecksumAlgorithm::kNone ||
+         test.validation_algo == ChecksumAlgorithm::kMD5);
+    bool disable_md5 =
+        (test.validation_algo == ChecksumAlgorithm::kNone ||
+         test.validation_algo == ChecksumAlgorithm::kCrc32c);
+    auto function = CreateHashFunction(test.crc32_value, disable_crc32c,
+                                       test.md5_value, disable_md5);
     ASSERT_STATUS_OK(function->Update(/*offset=*/0, kQuickFox));
     auto const actual = function->Finish();
     EXPECT_EQ(test.crc32c_expected, actual.crc32c);

google/cloud/storage/internal/hash_validator.cc

@@ -57,15 +57,17 @@ std::unique_ptr<HashValidator> CreateHashValidator(
     ReadObjectRangeRequest const& request) {
   if (request.RequiresRangeHeader()) return CreateNullHashValidator();
 
-  auto const settings = GetDownloadChecksumSettings(google::cloud::internal::CurrentOptions());
+  auto const settings = GetDownloadChecksumSettings(
+      google::cloud::internal::CurrentOptions());
   auto const disable_md5 = settings.md5;
   auto const disable_crc32c = settings.crc32c;
   return CreateHashValidator(disable_md5, disable_crc32c);
 }
 
 std::unique_ptr<HashValidator> CreateHashValidator(
     ResumableUploadRequest const& request) {
-  auto const settings = GetUploadChecksumSettings(google::cloud::internal::CurrentOptions());
+  auto const settings = GetUploadChecksumSettings(
+      google::cloud::internal::CurrentOptions());
   auto const disable_md5 = settings.md5;
   auto const disable_crc32c = settings.crc32c;
   return CreateHashValidator(disable_md5, disable_crc32c);

google/cloud/storage/parallel_upload.h

@@ -700,9 +700,9 @@ NonResumableParallelUploadState::Create(Client client,
   std::vector<ObjectWriteStream> streams;
 
   auto upload_options = StaticTupleFilter<
-      Among<ContentEncoding, ContentType,
-            UploadChecksumValidationOption, EncryptionKey, KmsKeyName,
-            PredefinedAcl, UserProject, WithObjectMetadata>::TPred>(
+      Among<ContentEncoding, ContentType, UploadChecksumValidationOption,
+            EncryptionKey, KmsKeyName, PredefinedAcl, UserProject,
+            WithObjectMetadata>::TPred>(
       std::move(options));
   for (std::size_t i = 0; i < num_shards; ++i) {
     ResumableUploadRequest request(
@@ -806,9 +806,8 @@ StatusOr<ResumableParallelUploadState> ResumableParallelUploadState::CreateNew(
 
   auto upload_options = std::tuple_cat(
       StaticTupleFilter<
-          Among<ContentEncoding, ContentType,
-                 UploadChecksumValidationOption, EncryptionKey,
-                KmsKeyName, PredefinedAcl, UserProject,
+          Among<ContentEncoding, ContentType, UploadChecksumValidationOption,
+                EncryptionKey, KmsKeyName, PredefinedAcl, UserProject,
                 WithObjectMetadata>::TPred>(options),
       std::make_tuple(UseResumableUploadSession("")));
   for (std::size_t i = 0; i < num_shards; ++i) {
@@ -865,8 +864,7 @@ StatusOr<ResumableParallelUploadState> ResumableParallelUploadState::Resume(
   }
 
   auto read_options = std::tuple_cat(
-      StaticTupleFilter<Among<
-                              UploadChecksumValidationOption, EncryptionKey,
+      StaticTupleFilter<Among<UploadChecksumValidationOption, EncryptionKey,
                               Generation, UserProject>::TPred>(options),
       std::make_tuple(IfGenerationMatch(state_and_gen->second)));
 
@@ -916,9 +914,9 @@ StatusOr<ResumableParallelUploadState> ResumableParallelUploadState::Resume(
   std::vector<ObjectWriteStream> streams;
 
   auto upload_options = StaticTupleFilter<
-      Among<ContentEncoding, ContentType,
-            UploadChecksumValidationOption, EncryptionKey, KmsKeyName,
-            PredefinedAcl, UserProject, WithObjectMetadata>::TPred>(
+      Among<ContentEncoding, ContentType, UploadChecksumValidationOption,
+            EncryptionKey, KmsKeyName, PredefinedAcl, UserProject,
+            WithObjectMetadata>::TPred>(
       std::move(options));
   for (auto& stream_desc : persistent_state->streams) {
     ResumableUploadRequest request(bucket_name,