Skip to content

feat(storage): Add unit test for AppendableUploadConnectionImpl#15200

Merged
v-pratap merged 5 commits into
googleapis:mainfrom
v-pratap:add-unit-test-fastbyte-02
Jun 10, 2025
Merged

feat(storage): Add unit test for AppendableUploadConnectionImpl#15200
v-pratap merged 5 commits into
googleapis:mainfrom
v-pratap:add-unit-test-fastbyte-02

Conversation

@v-pratap
Copy link
Copy Markdown
Contributor

@v-pratap v-pratap commented Jun 6, 2025 •
edited by scotthart
Loading

This change introduces a new test file, connection_impl_appendable_upload_test.cc, to thoroughly verify the asynchronous appendable upload functionality. Following tests are included in this commit:

StartAppendableObjectUploadSuccess
ResumeAppendableObjectUploadSuccess
AppendableUploadTooManyTransients
AppendableUploadPermanentError

This change is Reviewable

@v-pratap v-pratap requested review from a team June 6, 2025 09:26
@v-pratap v-pratap changed the title feat(storage) : Add unit test for AppendableUploadConnectionImpl feat(storage): Add unit test for AppendableUploadConnectionImpl Jun 6, 2025
@v-pratap v-pratap force-pushed the add-unit-test-fastbyte-02 branch from dd94f88 to e8663ec Compare June 6, 2025 09:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (acd4884) to head (369f2b5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #15200    +/-   ##
========================================
  Coverage   92.95%   92.95%            
========================================
  Files        2393     2394     +1     
  Lines      215318   215516   +198     
========================================
+ Hits       200140   200339   +199     
+ Misses      15178    15177     -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v-pratap v-pratap requested a review from bajajneha27 June 6, 2025 10:37
scotthart
scotthart previously approved these changes Jun 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bajajneha27)

google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc line 1 at r1 (raw file):

// Copyright 2024 Google LLC

Please update the copyright year to match the year when the file was first added.

scotthart
scotthart previously approved these changes Jun 6, 2025
View reviewed changes
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jun 7, 2025
bajajneha27
bajajneha27 previously approved these changes Jun 9, 2025
View reviewed changes
@v-pratap
Copy link
Copy Markdown
Contributor Author

v-pratap commented Jun 9, 2025

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bajajneha27)

google/cloud/storage/internal/async/connection_impl_appendable_upload_test.cc line 1 at r1 (raw file):

// Copyright 2024 Google LLC

Please update the copyright year to match the year when the file was first added.

Done.

@v-pratap v-pratap closed this Jun 9, 2025
@v-pratap v-pratap reopened this Jun 9, 2025
@v-pratap v-pratap force-pushed the add-unit-test-fastbyte-02 branch from a71a3fa to ce2d211 Compare June 9, 2025 09:17
@v-pratap v-pratap enabled auto-merge (squash) June 9, 2025 11:35
@v-pratap v-pratap force-pushed the add-unit-test-fastbyte-02 branch from ce2d211 to 369f2b5 Compare June 10, 2025 03:06
@v-pratap v-pratap merged commit 2d8e23a into googleapis:main Jun 10, 2025
77 of 78 checks passed
cuiy0006 pushed a commit to cuiy0006/google-cloud-cpp that referenced this pull request Jun 10, 2025
@v-pratap @cuiy0006
feat(storage): Add unit test for AppendableUploadConnectionImpl (goog…
fc06716 
…leapis#15200)

* feat(storage) : Add unit test for AppendableUploadConnectionImpl

* Remove the unwanted comment.

* Remove unnecesary declerations

* Update the copyright year

* remove the unwanted declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@scotthart scotthart scotthart left review comments

+1 more reviewer

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v-pratap @bajajneha27 @scotthart @ddelgrosso1