fix(storage): Do not move while creating current variable#15237
Merged
v-pratap merged 1 commit intogoogleapis:mainfrom Jun 30, 2025
Merged
fix(storage): Do not move while creating current variable#15237v-pratap merged 1 commit intogoogleapis:mainfrom
v-pratap merged 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
bajajneha27
approved these changes
Jun 26, 2025
bajajneha27
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15237 +/- ##
==========================================
- Coverage 92.93% 92.93% -0.01%
==========================================
Files 2394 2394
Lines 215352 215352
==========================================
- Hits 200132 200131 -1
- Misses 15220 15221 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Jun 26, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @v-pratap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The p.options is moved two times in this function, which is causing empty option at later stage.
This change is